Sign upLogin

varvet/godmin

View on GitHub
Star
lib/godmin/helpers/forms.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

        if @object.has_attribute?(attribute)
Severity: Minor
Found in lib/godmin/helpers/forms.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Indent the first parameter one step more than options.deep_merge(.
Open

          value: datetime_value(attribute, options, :datetimepicker),
          data: { behavior: "datetimepicker" }
Severity: Minor
Found in lib/godmin/helpers/forms.rb by rubocop

This cop checks the indentation of the first parameter in a method call. Parameters after the first one are checked by Style/AlignParameters, not by this cop.

Example:

# bad
some_method(
first_param,
second_param)

# good
some_method(
  first_param,
second_param)

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

        if @object.has_attribute?(attribute)
Severity: Minor
Found in lib/godmin/helpers/forms.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Indent the first parameter one step more than html_options.deep_merge(.
Open

            data: { behavior: "select-box" }
Severity: Minor
Found in lib/godmin/helpers/forms.rb by rubocop

This cop checks the indentation of the first parameter in a method call. Parameters after the first one are checked by Style/AlignParameters, not by this cop.

Example:

# bad
some_method(
first_param,
second_param)

# good
some_method(
  first_param,
second_param)

Indent the first parameter one step more than options.deep_merge(.
Open

          value: datetime_value(attribute, options, :datepicker),
          data: { behavior: "datepicker" }
Severity: Minor
Found in lib/godmin/helpers/forms.rb by rubocop

This cop checks the indentation of the first parameter in a method call. Parameters after the first one are checked by Style/AlignParameters, not by this cop.

Example:

# bad
some_method(
first_param,
second_param)

# good
some_method(
  first_param,
second_param)

There are no issues that match your filters.

Category
Status