Sign upLogin

varvet/godmin

View on GitHub
Star
lib/godmin/resources/resource_controller/batch_actions.rb

Summary

Maintainability
A
25 mins
Test Coverage

Assignment Branch Condition size for perform_batch_action is too high. [33.3/15]
Open

        def perform_batch_action
          return unless params[:batch_action].present?

          set_resource_service
          set_resource_class
Severity: Minor
Found in lib/godmin/resources/resource_controller/batch_actions.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method perform_batch_action has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def perform_batch_action
          return unless params[:batch_action].present?

          set_resource_service
          set_resource_class
Severity: Minor
Found in lib/godmin/resources/resource_controller/batch_actions.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use if params[:batch_action].blank? instead of unless params[:batch_action].present?.
Open

          return unless params[:batch_action].present?
Severity: Minor
Found in lib/godmin/resources/resource_controller/batch_actions.rb by rubocop

This cops checks for code that can be changed to blank?. Settings: NilOrEmpty: Convert checks for nil or empty? to blank? NotPresent: Convert usages of not present? to blank? UnlessPresent: Convert usages of unless present? to blank?

Example:

# NilOrEmpty: true
  # bad
  foo.nil? || foo.empty?
  foo == nil || foo.empty?

  # good
  foo.blank?

# NotPresent: true
  # bad
  !foo.present?

  # good
  foo.blank?

# UnlessPresent: true
  # bad
  something unless foo.present?
  unless foo.present?
    something
  end

  # good
  something if foo.blank?
  if foo.blank?
    something
  end

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

          if authorization_enabled?
Severity: Minor
Found in lib/godmin/resources/resource_controller/batch_actions.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

There are no issues that match your filters.

Category
Status