Sign upLogin

vcr/vcr

View on GitHub
Star
lib/vcr/structs.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File structs.rb has 372 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'base64'
require 'delegate'
require 'time'

module VCR
Severity: Minor
Found in lib/vcr/structs.rb - About 4 hrs to fix

    Method try_encode_string has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

              def try_encode_string(string, encoding)
            return string if encoding.nil? || string.encoding.name == encoding

            # ASCII-8BIT just means binary, so encoding to it is nonsensical
            # and yet "\u00f6".encode("ASCII-8BIT") raises an error.
    Severity: Minor
    Found in lib/vcr/structs.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method filter_object! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def filter_object!(object, text, replacement_text)
        if object.respond_to?(:gsub)
          object.gsub!(text, replacement_text) if object.include?(text)
        elsif Hash === object
          filter_hash!(object, text, replacement_text)
    Severity: Minor
    Found in lib/vcr/structs.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status