vdelacou/iblis-ui

View on GitHub
src/components/form_components/change_password_form/index.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function renderFormField has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    type: string, fieldName: string, label: string, submitting: boolean, needHelpPassword: boolean, passwordExplainLabel: string, theme: Theme,
    validateFunction: Array<(value: string, allValues: ChangePasswordFormValues, props: ChangePasswordFormProps) => string | undefined>, isLoading?: boolean) {
Severity: Major
Found in src/components/form_components/change_password_form/index.tsx - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    <Grid container={true} >
                        <Hidden only={'xs'}>
                            <Grid item={true} sm={3} >
                                {' '}
                            </Grid>
    src/components/form_components/user_profile_form/index.tsx on lines 189..203

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 142.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    function validatePasswordDigit(value: string, _allValues: ChangePasswordFormValues, props: ChangePasswordFormProps) {
        const numDigit = value.length - value.replace(/[0-9]/g, '').length;
        if (numDigit < props.minimumDigitPassword) {
            return props.minimumDigitErrorLabel;
        }
    src/components/form_components/change_password_form/index.tsx on lines 206..212
    src/components/form_components/change_password_form/index.tsx on lines 214..220
    src/components/form_components/change_password_form/index.tsx on lines 222..228
    src/components/form_components/force_change_password_form/index.tsx on lines 171..177
    src/components/form_components/force_change_password_form/index.tsx on lines 179..185
    src/components/form_components/force_change_password_form/index.tsx on lines 187..193
    src/components/form_components/password_confirm_form/index.tsx on lines 212..218
    src/components/form_components/password_confirm_form/index.tsx on lines 220..226
    src/components/form_components/password_confirm_form/index.tsx on lines 228..234
    src/components/form_components/password_confirm_form/index.tsx on lines 236..242
    src/components/form_components/signup_form/index.tsx on lines 222..228
    src/components/form_components/signup_form/index.tsx on lines 230..236
    src/components/form_components/signup_form/index.tsx on lines 238..244
    src/components/form_components/signup_form/index.tsx on lines 246..252

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    function validatePasswordUppercase(value: string, _allValues: ChangePasswordFormValues, props: ChangePasswordFormProps) {
        const numUpper = value.length - value.replace(/[A-Z]/g, '').length;
        if (numUpper < props.minimumUppercasePassword) {
            return props.minimumUppercaseErrorLabel;
        }
    src/components/form_components/change_password_form/index.tsx on lines 214..220
    src/components/form_components/change_password_form/index.tsx on lines 222..228
    src/components/form_components/change_password_form/index.tsx on lines 230..236
    src/components/form_components/force_change_password_form/index.tsx on lines 171..177
    src/components/form_components/force_change_password_form/index.tsx on lines 179..185
    src/components/form_components/force_change_password_form/index.tsx on lines 187..193
    src/components/form_components/password_confirm_form/index.tsx on lines 212..218
    src/components/form_components/password_confirm_form/index.tsx on lines 220..226
    src/components/form_components/password_confirm_form/index.tsx on lines 228..234
    src/components/form_components/password_confirm_form/index.tsx on lines 236..242
    src/components/form_components/signup_form/index.tsx on lines 222..228
    src/components/form_components/signup_form/index.tsx on lines 230..236
    src/components/form_components/signup_form/index.tsx on lines 238..244
    src/components/form_components/signup_form/index.tsx on lines 246..252

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    function validatePasswordLowercase(value: string, _allValues: ChangePasswordFormValues, props: ChangePasswordFormProps) {
        const numLower = value.length - value.replace(/[a-z]/g, '').length;
        if (numLower < props.minimumLowercasePassword) {
            return props.minimumLowercaseErrorLabel;
        }
    src/components/form_components/change_password_form/index.tsx on lines 206..212
    src/components/form_components/change_password_form/index.tsx on lines 222..228
    src/components/form_components/change_password_form/index.tsx on lines 230..236
    src/components/form_components/force_change_password_form/index.tsx on lines 171..177
    src/components/form_components/force_change_password_form/index.tsx on lines 179..185
    src/components/form_components/force_change_password_form/index.tsx on lines 187..193
    src/components/form_components/password_confirm_form/index.tsx on lines 212..218
    src/components/form_components/password_confirm_form/index.tsx on lines 220..226
    src/components/form_components/password_confirm_form/index.tsx on lines 228..234
    src/components/form_components/password_confirm_form/index.tsx on lines 236..242
    src/components/form_components/signup_form/index.tsx on lines 222..228
    src/components/form_components/signup_form/index.tsx on lines 230..236
    src/components/form_components/signup_form/index.tsx on lines 238..244
    src/components/form_components/signup_form/index.tsx on lines 246..252

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    function validatePasswordSpecialChar(value: string, _allValues: ChangePasswordFormValues, props: ChangePasswordFormProps) {
        const numSpecial = value.length - value.replace(/[$@$!%*#?&]/g, '').length;
        if (numSpecial < props.minimumSpecialCharPassword) {
            return props.minimumSpecialCharErrorLabel;
        }
    src/components/form_components/change_password_form/index.tsx on lines 206..212
    src/components/form_components/change_password_form/index.tsx on lines 214..220
    src/components/form_components/change_password_form/index.tsx on lines 230..236
    src/components/form_components/force_change_password_form/index.tsx on lines 171..177
    src/components/form_components/force_change_password_form/index.tsx on lines 179..185
    src/components/form_components/force_change_password_form/index.tsx on lines 187..193
    src/components/form_components/password_confirm_form/index.tsx on lines 212..218
    src/components/form_components/password_confirm_form/index.tsx on lines 220..226
    src/components/form_components/password_confirm_form/index.tsx on lines 228..234
    src/components/form_components/password_confirm_form/index.tsx on lines 236..242
    src/components/form_components/signup_form/index.tsx on lines 222..228
    src/components/form_components/signup_form/index.tsx on lines 230..236
    src/components/form_components/signup_form/index.tsx on lines 238..244
    src/components/form_components/signup_form/index.tsx on lines 246..252

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    function validatePasswordLength(value: string, _allValues: ChangePasswordFormValues, props: ChangePasswordFormProps) {
        if (value.length < props.minimumPasswordLength || value.length > props.maximumPasswordLength) {
            return props.passwordLengthErrorLabel;
        }
        return undefined;
    src/components/form_components/force_change_password_form/index.tsx on lines 164..169
    src/components/form_components/login_form/index.tsx on lines 165..170
    src/components/form_components/password_confirm_form/index.tsx on lines 205..210
    src/components/form_components/signup_form/index.tsx on lines 215..220

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    function requiredTextField(value: string, _allValues: ChangePasswordFormValues, props: ChangePasswordFormProps) {
        return value && value.trim() !== '' ? undefined : props.requiredErrorLabel;
    }
    src/components/form_components/confirm_signup_form/index.tsx on lines 144..146
    src/components/form_components/delete_account_form/index.tsx on lines 215..217
    src/components/form_components/force_change_password_form/index.tsx on lines 153..155
    src/components/form_components/login_form/index.tsx on lines 154..156
    src/components/form_components/password_confirm_form/index.tsx on lines 194..196
    src/components/form_components/reset_password_form/index.tsx on lines 102..104
    src/components/form_components/signup_form/index.tsx on lines 197..199
    src/components/form_components/user_profile_form/index.tsx on lines 211..213

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    function validatePassword(value: string, allValues: ChangePasswordFormValues, props: ChangePasswordFormProps) {
        if (value !== allValues.password) {
            return props.passwordNotIdentical;
        }
        return undefined;
    Severity: Major
    Found in src/components/form_components/change_password_form/index.tsx and 3 other locations - About 50 mins to fix
    src/components/form_components/force_change_password_form/index.tsx on lines 157..162
    src/components/form_components/password_confirm_form/index.tsx on lines 198..203
    src/components/form_components/signup_form/index.tsx on lines 208..213

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    const ChangePasswordWithTheme: React.ComponentType<ChangePasswordFormProps & InjectedFormProps<ChangePasswordFormValues, ChangePasswordFormProps>> =
        withTheme()(ChangePasswordFormBase);
    Severity: Major
    Found in src/components/form_components/change_password_form/index.tsx and 8 other locations - About 35 mins to fix
    src/components/form_components/confirm_signup_form/index.tsx on lines 148..149
    src/components/form_components/delete_account_form/index.tsx on lines 226..227
    src/components/form_components/login_form/index.tsx on lines 172..173
    src/components/form_components/managed_simple_add_form/index.tsx on lines 82..83
    src/components/form_components/managed_simple_list_form/index.tsx on lines 364..365
    src/components/form_components/password_confirm_form/index.tsx on lines 243..244
    src/components/form_components/reset_password_form/index.tsx on lines 113..114
    src/components/form_components/signup_form/index.tsx on lines 253..254

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Array type using 'Array<t>' is forbidden. Use 'T[]' instead.</t>
    Open

        validateFunction: Array<(value: string, allValues: ChangePasswordFormValues, props: ChangePasswordFormProps) => string | undefined>, isLoading?: boolean) {

    Rule: array-type

    Requires using either 'T[]' or 'Array<t>' for arrays.</t>

    Notes
    • TypeScript Only
    • Has Fix

    Config

    One of the following arguments must be provided:

    • "array" enforces use of T[] for all types T.
    • "generic" enforces use of Array<T> for all types T.
    • "array-simple" enforces use of T[] if T is a simple type (primitive or type reference).
    Examples
    "array-type": true,array
    "array-type": true,generic
    "array-type": true,array-simple
    Schema
    {
      "type": "string",
      "enum": [
        "array",
        "generic",
        "array-simple"
      ]
    }

    For more information see this page.

    There are no issues that match your filters.

    Category
    Status