Sign upLogin

vdelacou/iblis-ui

View on GitHub
Star
src/components/form_components/login_form/index.tsx

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                <Grid container={true} justify="space-between" >
                    {/* create account */}
                    <Grid item={true} >
                        <Typography variant="subheading">
                            <ButtonBase onClick={() => createAccount()} disabled={submitting || isLoading}>
Severity: Major
Found in src/components/form_components/login_form/index.tsx and 2 other locations - About 6 hrs to fix
src/components/form_components/confirm_signup_form/index.tsx on lines 119..137
src/components/form_components/reset_password_form/index.tsx on lines 77..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 173.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                <Grid container={true} >
                    <Grid item={true} xs={12}>
                        <Field
                            type="text"
                            name="email"
Severity: Major
Found in src/components/form_components/login_form/index.tsx and 3 other locations - About 3 hrs to fix
src/components/form_components/login_form/index.tsx on lines 105..117
src/components/form_components/reset_password_form/index.tsx on lines 63..75
src/components/form_components/signup_form/index.tsx on lines 131..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                <Grid container={true} >
                    <Grid item={true} xs={12}>
                        <Field
                            type="password"
                            name="password"
Severity: Major
Found in src/components/form_components/login_form/index.tsx and 3 other locations - About 3 hrs to fix
src/components/form_components/login_form/index.tsx on lines 91..103
src/components/form_components/reset_password_form/index.tsx on lines 63..75
src/components/form_components/signup_form/index.tsx on lines 131..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                <Grid container={true} justify="flex-end" >
                    <Grid item={true}>
                        <Typography align="center">
                            <ButtonBase onClick={() => forgetPassword()} disabled={submitting || isLoading}>
                                {forgetPasswordLabel}
Severity: Major
Found in src/components/form_components/login_form/index.tsx and 1 other location - About 3 hrs to fix
src/components/form_components/confirm_signup_form/index.tsx on lines 109..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

function validateLengthPassword(value: string, _allValues: LoginFormValues, props: LoginFormProps) {
    if (value.length < props.minimumPasswordLength || value.length > props.maximumPasswordLength) {
        return props.passwordLengthErrorLabel;
    }
    return undefined;
Severity: Major
Found in src/components/form_components/login_form/index.tsx and 4 other locations - About 1 hr to fix
src/components/form_components/change_password_form/index.tsx on lines 199..204
src/components/form_components/force_change_password_form/index.tsx on lines 164..169
src/components/form_components/password_confirm_form/index.tsx on lines 205..210
src/components/form_components/signup_form/index.tsx on lines 215..220

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

function requiredTextField(value: string, _allValues: LoginFormValues, props: LoginFormProps) {
    return value && value.trim() !== '' ? undefined : props.requiredErrorLabel;
}
Severity: Major
Found in src/components/form_components/login_form/index.tsx and 8 other locations - About 1 hr to fix
src/components/form_components/change_password_form/index.tsx on lines 188..190
src/components/form_components/confirm_signup_form/index.tsx on lines 144..146
src/components/form_components/delete_account_form/index.tsx on lines 215..217
src/components/form_components/force_change_password_form/index.tsx on lines 153..155
src/components/form_components/password_confirm_form/index.tsx on lines 194..196
src/components/form_components/reset_password_form/index.tsx on lines 102..104
src/components/form_components/signup_form/index.tsx on lines 197..199
src/components/form_components/user_profile_form/index.tsx on lines 211..213

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

function validateEmail(value: string, _allValues: LoginFormValues, props: LoginFormProps) {
    if (!/^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i.test(value)) {
        return props.emailNotValidErrorLabel;
    }
    return undefined;
Severity: Major
Found in src/components/form_components/login_form/index.tsx and 3 other locations - About 55 mins to fix
src/components/form_components/delete_account_form/index.tsx on lines 219..224
src/components/form_components/reset_password_form/index.tsx on lines 106..111
src/components/form_components/signup_form/index.tsx on lines 201..206

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

const LoginWithTheme: React.ComponentType<LoginFormProps & InjectedFormProps<LoginFormValues, LoginFormProps>> =
    withTheme()(LoginFormBase);
Severity: Major
Found in src/components/form_components/login_form/index.tsx and 8 other locations - About 35 mins to fix
src/components/form_components/change_password_form/index.tsx on lines 238..239
src/components/form_components/confirm_signup_form/index.tsx on lines 148..149
src/components/form_components/delete_account_form/index.tsx on lines 226..227
src/components/form_components/managed_simple_add_form/index.tsx on lines 82..83
src/components/form_components/managed_simple_list_form/index.tsx on lines 364..365
src/components/form_components/password_confirm_form/index.tsx on lines 243..244
src/components/form_components/reset_password_form/index.tsx on lines 113..114
src/components/form_components/signup_form/index.tsx on lines 253..254

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status