vdelacou/iblis-ui

View on GitHub
src/components/form_components/managed_simple_add_form/index.tsx

Summary

Maintainability
A
35 mins
Test Coverage

Similar blocks of code found in 9 locations. Consider refactoring.
Open

const ManagedAddSimpleFormWithTheme: React.ComponentType<ManagedAddSimpleFormProps & InjectedFormProps<ManagedAddSimpleFormValues, ManagedAddSimpleFormProps>> =
    withTheme()(ManagedAddSimpleFormBase);
src/components/form_components/change_password_form/index.tsx on lines 238..239
src/components/form_components/confirm_signup_form/index.tsx on lines 148..149
src/components/form_components/delete_account_form/index.tsx on lines 226..227
src/components/form_components/login_form/index.tsx on lines 172..173
src/components/form_components/managed_simple_list_form/index.tsx on lines 364..365
src/components/form_components/password_confirm_form/index.tsx on lines 243..244
src/components/form_components/reset_password_form/index.tsx on lines 113..114
src/components/form_components/signup_form/index.tsx on lines 253..254

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Array type using 'Array<t>' is forbidden. Use 'T[]' instead.</t>
Open

    validateFunctions: Array<(value: string, allValues: ManagedAddSimpleFormValues, props: ManagedAddSimpleFormProps) => string | undefined>;

Rule: array-type

Requires using either 'T[]' or 'Array<t>' for arrays.</t>

Notes
  • TypeScript Only
  • Has Fix

Config

One of the following arguments must be provided:

  • "array" enforces use of T[] for all types T.
  • "generic" enforces use of Array<T> for all types T.
  • "array-simple" enforces use of T[] if T is a simple type (primitive or type reference).
Examples
"array-type": true,array
"array-type": true,generic
"array-type": true,array-simple
Schema
{
  "type": "string",
  "enum": [
    "array",
    "generic",
    "array-simple"
  ]
}

For more information see this page.

There are no issues that match your filters.

Category
Status