Sign upLogin

vdelacou/iblis-ui

View on GitHub
Star
src/components/form_components/managed_simple_form/index.tsx

Summary

Maintainability
A
2 hrs
Test Coverage

Function ManagedSimpleFormBase has 101 lines of code (exceeds 100 allowed). Consider refactoring.
Open

const ManagedSimpleFormBase: React.StatelessComponent<ManagedSimpleFormProps> = (props) => {

    const {
        data,
        idFieldName, displayFieldName,
Severity: Major
Found in src/components/form_components/managed_simple_form/index.tsx - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const requiredEditTextField = (value: string, _allValues: ManagedSimpleListFormValues, _props: ManagedSimpleListFormProps) => {
    return value && value.trim() !== '' ? undefined : 'Required';
};
    Severity: Minor
    Found in src/components/form_components/managed_simple_form/index.tsx and 1 other location - About 55 mins to fix
    src/components/form_components/managed_simple_form/index.tsx on lines 232..234

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const requiredAddTextField = (value: string, _allValues: ManagedAddSimpleFormValues, _props: ManagedAddSimpleFormProps) => {
    return value && value.trim() !== '' ? undefined : 'Required';
};
    Severity: Minor
    Found in src/components/form_components/managed_simple_form/index.tsx and 1 other location - About 55 mins to fix
    src/components/form_components/managed_simple_form/index.tsx on lines 235..237

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Array type using 'Array<t>' is forbidden. Use 'T[]' instead.</t>
    Open

        validateEditFunctions?: Array<(value: string, allValues: ManagedSimpleListFormValues, props: ManagedSimpleListFormProps) => string | undefined>;
    Severity: Minor
    Found in src/components/form_components/managed_simple_form/index.tsx by tslint

    Rule: array-type

    Requires using either 'T[]' or 'Array<t>' for arrays.</t>

    Notes
    • TypeScript Only
    • Has Fix

    Config

    One of the following arguments must be provided:

    • "array" enforces use of T[] for all types T.
    • "generic" enforces use of Array<T> for all types T.
    • "array-simple" enforces use of T[] if T is a simple type (primitive or type reference).
    Examples
    "array-type": true,array
    "array-type": true,generic
    "array-type": true,array-simple
    Schema
    {
  "type": "string",
  "enum": [
    "array",
    "generic",
    "array-simple"
  ]
}

    For more information see this page.

    Array type using 'Array<t>' is forbidden. Use 'T[]' instead.</t>
    Open

        menuAction?: Array<{
        /**
         * The label to display on the menu
         */
        label: string;
    Severity: Minor
    Found in src/components/form_components/managed_simple_form/index.tsx by tslint

    Rule: array-type

    Requires using either 'T[]' or 'Array<t>' for arrays.</t>

    Notes
    • TypeScript Only
    • Has Fix

    Config

    One of the following arguments must be provided:

    • "array" enforces use of T[] for all types T.
    • "generic" enforces use of Array<T> for all types T.
    • "array-simple" enforces use of T[] if T is a simple type (primitive or type reference).
    Examples
    "array-type": true,array
    "array-type": true,generic
    "array-type": true,array-simple
    Schema
    {
  "type": "string",
  "enum": [
    "array",
    "generic",
    "array-simple"
  ]
}

    For more information see this page.

    Array type using 'Array<t>' is forbidden. Use 'T[]' instead.</t>
    Open

        data: Array<ManagedSimpleFormData<object>>;
    Severity: Minor
    Found in src/components/form_components/managed_simple_form/index.tsx by tslint

    Rule: array-type

    Requires using either 'T[]' or 'Array<t>' for arrays.</t>

    Notes
    • TypeScript Only
    • Has Fix

    Config

    One of the following arguments must be provided:

    • "array" enforces use of T[] for all types T.
    • "generic" enforces use of Array<T> for all types T.
    • "array-simple" enforces use of T[] if T is a simple type (primitive or type reference).
    Examples
    "array-type": true,array
    "array-type": true,generic
    "array-type": true,array-simple
    Schema
    {
  "type": "string",
  "enum": [
    "array",
    "generic",
    "array-simple"
  ]
}

    For more information see this page.

    Array type using 'Array<t>' is forbidden. Use 'T[]' instead.</t>
    Open

        validateAddFunctions?: Array<(value: string, allValues: ManagedAddSimpleFormValues, props: ManagedAddSimpleFormProps) => string | undefined>;
    Severity: Minor
    Found in src/components/form_components/managed_simple_form/index.tsx by tslint

    Rule: array-type

    Requires using either 'T[]' or 'Array<t>' for arrays.</t>

    Notes
    • TypeScript Only
    • Has Fix

    Config

    One of the following arguments must be provided:

    • "array" enforces use of T[] for all types T.
    • "generic" enforces use of Array<T> for all types T.
    • "array-simple" enforces use of T[] if T is a simple type (primitive or type reference).
    Examples
    "array-type": true,array
    "array-type": true,generic
    "array-type": true,array-simple
    Schema
    {
  "type": "string",
  "enum": [
    "array",
    "generic",
    "array-simple"
  ]
}

    For more information see this page.

    There are no issues that match your filters.

    Category
    Status