Sign upLogin

vegantech/sims

View on GitHub
Star
app/controllers/students_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method enforce_session_selections has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def enforce_session_selections
    return true unless params[:id]
        # raise "I'm here" if selected_students_ids.nil?
    if selected_student_ids and selected_student_ids.include?(params[:id])
      self.current_student_id=params[:id]
Severity: Minor
Found in app/controllers/students_controller.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      redirect_to students_url and return false
Severity: Major
Found in app/controllers/students_controller.rb - About 30 mins to fix

    Method index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def index
    try_to_auto_select_school or return false unless current_school_id
    flash[:notice]= "Please choose some search criteria" and redirect_to [current_school,StudentSearch] and return unless session[:search]
    Severity: Minor
    Found in app/controllers/students_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status