Sign upLogin

vegantech/sims

View on GitHub
Star
app/helpers/application_helper.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method link_to_if_authorized has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def link_to_if_authorized(name, options = {}, html_options = {}, *rest)
    #TODO Test then Refactor!!!     This is a spike.
   # hsh = ::ActionController::Routing::Routes.recognize_path url.gsub(/\?.*$/,''), :method=> :get
    if options.is_a?String
      url = options
Severity: Minor
Found in app/helpers/application_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method link_to_with_icon has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def link_to_with_icon(name, url, suffix="")
    return "" if name.blank?
    ext = name.split(".").last.split("?").first
    file = name.split("." + ext).first.to_s.gsub(/_/," ") + suffix
    icon= ext.blank? ? "icon_htm.gif" : "icon_#{ext.downcase}.gif"
Severity: Minor
Found in app/helpers/application_helper.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status