lib/automated_intervention.rb
Method process_row has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
Open
def process_row line
student= check_student(line[:district_student_id]) or return false
int_def=check_intervention_definition(line[:intervention_definition_id]) or return false
intervention=int_def.interventions.build(:student => student, :user => @user, :start_date => line[:start_date],- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_row has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def process_row line
student= check_student(line[:district_student_id]) or return false
int_def=check_intervention_definition(line[:intervention_definition_id]) or return false
intervention=int_def.interventions.build(:student => student, :user => @user, :start_date => line[:start_date],Avoid too many return statements within this method. Open
Open
@messages << "Score is not between #{min} and #{max} #{line.to_s}" and return falseAvoid too many return statements within this method. Open
Open
check_for_duplicate(intervention,line) and return false