Sign upLogin

vegantech/sims

View on GitHub
Star
lib/referral_report.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method dates_of_sims_data has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def dates_of_sims_data


    referrals= Student.connection.select_all("select distinct s.district_student_id,r.id, r.created_at, (year(r.updated_at + INTERVAL 6 month))  as schoolyear
    from students s inner join recommendations r on r.student_id = s.id and r.promoted=true and r.recommendation=5
Severity: Major
Found in lib/referral_report.rb - About 2 hrs to fix

    Method referral_report has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def referral_report
    csv_string = ''
    CSV.generate(csv_string,:row_sep=>"\r\n") do |csv|
      csv << ["personID","referral_request","main_concerns","interventions_tried","family_involvement","external_factors","date","schoolyear"]
      dates_of_sims_data.each do |student|
    Severity: Minor
    Found in lib/referral_report.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status