veracross/consult

View on GitHub

Showing 5 of 5 total issues

Method render has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def render(save: true)
      if contents.empty? && @config[:skip_missing_template]
        return
      end

Severity: Minor
Found in lib/consult/template.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def load(config_dir: nil, force_render: false, verbose: nil)
      root directory: config_dir
      yaml = root.join('config', 'consult.yml')

      if verbose
Severity: Minor
Found in lib/consult.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_options has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def parse_options(argv)
      opts = {
        config_dir: Dir.pwd,
        force_render: true,
        verbose: true
Severity: Minor
Found in lib/consult/cli.rb - About 1 hr to fix

    Method consul_contents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def consul_contents(location)
          [@config[location]].compact.flatten.map do |key|
            Diplomat::Kv.get(key, {}, :reject, :return).force_encoding 'utf-8'
          rescue Diplomat::KeyNotFound
            if @config[:skip_missing_template]
    Severity: Minor
    Found in lib/consult/template.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method disk_contents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def disk_contents(location)
          [public_send(location)].compact.flatten.map do |file_path|
            File.read file_path, encoding: 'utf-8'
          rescue Errno::ENOENT
            if @config[:skip_missing_template]
    Severity: Minor
    Found in lib/consult/template.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language