verse/verse-javascript

View on GitHub

Showing 104 of 104 total issues

Avoid too many return statements within this function.
Open

            return {
                'group': 'TAG_GROUP',
                'cmd': cmdValues
            };
Severity: Major
Found in src/response.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return {
                    'group': 'TAG',
                    'cmd': cmdValues
                };
    Severity: Major
    Found in src/response.js - About 30 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              connectionTerminatedCallback: function(event) {
                  /*
                   *  callback function for end of session handling
                   * called when onClose websocket event is fired
                   */
      Severity: Minor
      Found in example/app_amd.js and 1 other location - About 30 mins to fix
      example/app_standalone.js on lines 135..142

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              33: function getNodeDestroy(opCode, receivedView, bufferPosition) {
                  return {
                      CMD: commands[opCode],
                      NODE_ID: receivedView.getUint32(bufferPosition + 2)
                  };
      Severity: Minor
      Found in src/node.js and 1 other location - About 30 mins to fix
      src/node.js on lines 104..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language