Sign upLogin

vfonic/solidify

View on GitHub
Star
app/fields/spree/product_fields.rb

Summary

Maintainability
A
40 mins
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    METHODS = %w(
      id available collections compare_at_price_max compare_at_price_min
      compare_at_price_varies content description featured_image
      first_available_variant handle images options options_with_values price
      price_max price_min price_varies selected_variant
Severity: Minor
Found in app/fields/spree/product_fields.rb and 2 other locations - About 25 mins to fix
app/fields/spree/line_item_fields.rb on lines 3..7
app/fields/spree/line_item_fields.rb on lines 10..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    JSON = %w(
      id available compare_at_price compare_at_price_max compare_at_price_min
      compare_at_price_varies content created_at description featured_image
      handle images options price price_max price_min price_varies published_at
      tags title type variants vendor
Severity: Minor
Found in app/fields/spree/product_fields.rb and 1 other location - About 15 mins to fix
app/fields/spree/variant_fields.rb on lines 9..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status