Sign upLogin

vibbix/BallroomCalculator

View on GitHub
Star

Showing 10 of 10 total issues

MainActivityInstrumentationTests has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

@RunWith(AndroidJUnit4.class)
@LargeTest
public class MainActivityInstrumentationTests {
    @Rule
    public ActivityTestRule mActivityRule = new ActivityTestRule<>(activity_main.class);
Severity: Minor
Found in app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
    public void verifyImperialCalculations() {
        onView(withId(R.id.switchMetric)).perform(setChecked(false));
        onView(withId(R.id.switchEasy)).perform(setChecked(false));
        onView(withId(R.id.seekEfficiency)).perform(setProgress(74));
    Severity: Major
    Found in app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java and 1 other location - About 2 hrs to fix
    app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 152..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 163.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
    public void verifyMetricCalculations() {
        onView(withId(R.id.switchMetric)).perform(setChecked(true));
        onView(withId(R.id.switchEasy)).perform(setChecked(false));
        onView(withId(R.id.seekEfficiency)).perform(setProgress(70));
    Severity: Major
    Found in app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java and 1 other location - About 2 hrs to fix
    app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 177..188

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 163.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
    public void verifyImperialCalculationsEasy() {
        onView(withId(R.id.switchMetric)).perform(setChecked(false));
        onView(withId(R.id.switchEasy)).perform(setChecked(true));
        onView(withId(R.id.decimalArea)).perform(ViewActions.replaceText("10.0"));
    Severity: Major
    Found in app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java and 1 other location - About 1 hr to fix
    app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 166..175

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 125.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
    public void verifyMetricCalculationsEasy() {
        onView(withId(R.id.switchMetric)).perform(setChecked(true));
        onView(withId(R.id.switchEasy)).perform(setChecked(true));
        onView(withId(R.id.decimalArea)).perform(ViewActions.replaceText("10.0"));
    Severity: Major
    Found in app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java and 1 other location - About 1 hr to fix
    app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 190..199

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 125.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
    public void changeToImperial() {
        onView(withId(R.id.switchMetric)).perform(setChecked(false));
        onView(withId(R.id.switchEasy)).perform(setChecked(false));
        onView(withId(R.id.txtunitSquared)).check(matches(withText(R.string.FeetSquared)));
    Severity: Major
    Found in app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java and 1 other location - About 1 hr to fix
    app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 114..122

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
    public void changeToMetric(){
        onView(withId(R.id.switchMetric)).perform(setChecked(true));
        onView(withId(R.id.switchEasy)).perform(setChecked(false));
        onView(withId(R.id.txtunitSquared)).check(matches(withText(R.string.MeterSquared)));
    Severity: Major
    Found in app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java and 1 other location - About 1 hr to fix
    app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 124..131

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method setChecked has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static ViewAction setChecked(final boolean checked) {
        return new ViewAction() {
            @Override
            public Matcher<View> getConstraints() {
                return new Matcher<View>() {
    Severity: Minor
    Found in app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java - About 1 hr to fix

      Method estimateBalls has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static int estimateBalls(double efficiency, double footage, double depth, double radius,
                                    BigDecimal measurementscale) {
      Severity: Minor
      Found in app/src/main/java/com/vibbix/ballroom/ObservableBallRoomCalculator.java - About 35 mins to fix

        Method setText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            @BindingAdapter("android:text")
    public static void setText(EditText view, double value) {
        boolean setValue = view.getText().length() == 0;
        if (setValue && value == 0.0D) {
            return;
        Severity: Minor
        Found in app/src/main/java/com/vibbix/ballroom/ObservableBallRoomCalculator.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language