Sign upLogin

vibbix/BallroomCalculator

View on GitHub
Star

Showing 4 of 10 total issues

MainActivityInstrumentationTests has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

@RunWith(AndroidJUnit4.class)
@LargeTest
public class MainActivityInstrumentationTests {
    @Rule
    public ActivityTestRule mActivityRule = new ActivityTestRule<>(activity_main.class);
Severity: Minor
Found in app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java - About 2 hrs to fix

    Method setChecked has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static ViewAction setChecked(final boolean checked) {
        return new ViewAction() {
            @Override
            public Matcher<View> getConstraints() {
                return new Matcher<View>() {
    Severity: Minor
    Found in app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java - About 1 hr to fix

      Method estimateBalls has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static int estimateBalls(double efficiency, double footage, double depth, double radius,
                                    BigDecimal measurementscale) {
      Severity: Minor
      Found in app/src/main/java/com/vibbix/ballroom/ObservableBallRoomCalculator.java - About 35 mins to fix

        Method setText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            @BindingAdapter("android:text")
    public static void setText(EditText view, double value) {
        boolean setValue = view.getText().length() == 0;
        if (setValue && value == 0.0D) {
            return;
        Severity: Minor
        Found in app/src/main/java/com/vibbix/ballroom/ObservableBallRoomCalculator.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language