Sign upLogin

victor-magarlamov/pg_partitioning

View on GitHub
Star

Showing 4 of 4 total issues

Method create_insert_master_function has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def create_insert_master_function
        @sql.execute "CREATE OR REPLACE FUNCTION #{@table_name}_insert_master() RETURNS TRIGGER AS $$
                       DECLARE
                         colname   text    := '#{@column_name.to_sym}';
                         colval    integer := NEW.#{@column_name.to_sym};
Severity: Minor
Found in lib/pg_partitioning/strategies/step.rb - About 1 hr to fix

    Method create_insert_master_function has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def create_insert_master_function
        @sql.execute "CREATE OR REPLACE FUNCTION #{@table_name}_insert_master() RETURNS TRIGGER AS $$
                       DECLARE
                         colname text      := '#{@column_name.to_sym}';
                         colval  timestamp := NEW.#{@column_name.to_sym};
    Severity: Minor
    Found in lib/pg_partitioning/strategies/date.rb - About 1 hr to fix

      Method create_insert_master_function has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def create_insert_master_function
        @sql.execute "CREATE OR REPLACE FUNCTION #{@table_name}_insert_master() RETURNS TRIGGER AS $$
                       DECLARE
                         colname text := '#{@column_name.to_sym}';
                         colval  text := NEW.#{@column_name.to_sym};
      Severity: Minor
      Found in lib/pg_partitioning/strategies/equal.rb - About 1 hr to fix

        Method valid? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def valid?
        if super
          @error_message = if !(@data_type.include?('timestamp') || @data_type.include?('date'))
                             I18n.t "pg_partitioning.failure.column_type"
                           elsif (@cond.blank? || !cond_valid?)
        Severity: Minor
        Found in lib/pg_partitioning/strategies/date.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language