Sign upLogin

victor0402/rest-api-client

View on GitHub
Star
lib/rest/api/client/json_parser.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method parse_json has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def self.parse_json(json, opts = {})
    begin
      json_response = JSON.parse json

      data_type = opts[:type]
Severity: Minor
Found in lib/rest/api/client/json_parser.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_instance has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def self.build_instance(data_type, instance_data)
    instance = data_type.new
    instance_data.each do |key, value|

      begin
Severity: Minor
Found in lib/rest/api/client/json_parser.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return json_data
Severity: Major
Found in lib/rest/api/client/json_parser.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return (opts[:default_return] || nil)
    Severity: Major
    Found in lib/rest/api/client/json_parser.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return json_response
      Severity: Major
      Found in lib/rest/api/client/json_parser.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status