Sign upLogin

victorbuild/laravel-sitemap

View on GitHub
Star
src/Victorbuild/Sitemap/Sitemap.php

Summary

Maintainability
F
3 days
Test Coverage
A
99%

Function addItem has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
Open

    public function addItem($params = [])
    {
        // if is multidimensional
        if (array_key_exists(1, $params)) {
            foreach ($params as $a) {
Severity: Minor
Found in src/Victorbuild/Sitemap/Sitemap.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function store has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    public function store($format = 'xml', $filename = 'sitemap', $path = null, $style = null)
    {
        // turn off caching for this method
        $this->model->setUseCache(false);
Severity: Minor
Found in src/Victorbuild/Sitemap/Sitemap.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addItem has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function addItem($params = [])
    {
        // if is multidimensional
        if (array_key_exists(1, $params)) {
            foreach ($params as $a) {
Severity: Major
Found in src/Victorbuild/Sitemap/Sitemap.php - About 3 hrs to fix

    File Sitemap.php has 281 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Victorbuild\Sitemap;

/**
    Severity: Minor
    Found in src/Victorbuild/Sitemap/Sitemap.php - About 2 hrs to fix

      Method store has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function store($format = 'xml', $filename = 'sitemap', $path = null, $style = null)
    {
        // turn off caching for this method
        $this->model->setUseCache(false);
      Severity: Major
      Found in src/Victorbuild/Sitemap/Sitemap.php - About 2 hrs to fix

        Method generate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function generate($format = 'xml', $style = null)
    {
        // check if caching is enabled, there is a cached content and its duration isn't expired
        if ($this->isCached()) {
            ('sitemapindex' == $format) ? $this->model->resetSitemaps($this->cache->get($this->model->getCacheKey())) : $this->model->resetItems($this->cache->get($this->model->getCacheKey()));
        Severity: Minor
        Found in src/Victorbuild/Sitemap/Sitemap.php - About 1 hr to fix

          Method add has 10 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function add($loc, $lastmod = null, $priority = null, $freq = null, $images = [], $title = null, $translations = [], $videos = [], $googlenews = [], $alternates = [])
          Severity: Major
          Found in src/Victorbuild/Sitemap/Sitemap.php - About 1 hr to fix

            Function generate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function generate($format = 'xml', $style = null)
    {
        // check if caching is enabled, there is a cached content and its duration isn't expired
        if ($this->isCached()) {
            ('sitemapindex' == $format) ? $this->model->resetSitemaps($this->cache->get($this->model->getCacheKey())) : $this->model->resetItems($this->cache->get($this->model->getCacheKey()));
            Severity: Minor
            Found in src/Victorbuild/Sitemap/Sitemap.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function __construct(array $config, CacheRepository $cache, ConfigRepository $configRepository, Filesystem $file, ResponseFactory $response, ViewFactory $view)
            Severity: Minor
            Found in src/Victorbuild/Sitemap/Sitemap.php - About 45 mins to fix

              Avoid too many return statements within this method.
              Open

                              return ['content' => $this->view->make('sitemap::sitemapindex', ['sitemaps' => $this->model->getSitemaps(), 'style' => $style])->render(), 'headers' => ['Content-type' => 'text/xml; charset=utf-8']];
              Severity: Major
              Found in src/Victorbuild/Sitemap/Sitemap.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return ['content' => $this->view->make('sitemap::'.$format, ['items' => $this->model->getItems(), 'style' => $style])->render(), 'headers' => ['Content-type' => 'text/xml; charset=utf-8']];
                Severity: Major
                Found in src/Victorbuild/Sitemap/Sitemap.php - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status