vijos/openvj

View on GitHub
src/Test/EventListener/HttpsRedirectionServiceTest.php

Summary

Maintainability
D
3 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testGetNoSSLTrueVisitHttpFromBrowser()
    {
        foreach ($this->ua_https as $ua) {
            $request = $this->getRequest($ua, false, ['nossl' => 'on']);
            $response = new Response();
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 1 other location - About 5 hrs to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 173..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 197.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testGetNoSSLTrueVisitHttpsFromBrowser()
    {
        foreach ($this->ua_https as $ua) {
            $request = $this->getRequest($ua, true, ['nossl' => 'on']);
            $response = new Response();
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 1 other location - About 5 hrs to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 152..171

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 197.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testCookieNoSSLTrueVisitHttpFromBrowser()
    {
        foreach ($this->ua_https as $ua) {
            $request = $this->getRequest($ua, false, [], ['nossl' => 'on']);
            $response = new Response();
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 1 other location - About 3 hrs to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 209..222

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testCookieNoSSLTrueVisitHttpsFromBrowser()
    {
        foreach ($this->ua_https as $ua) {
            $request = $this->getRequest($ua, true, [], ['nossl' => 'on']);
            $response = new Response();
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 1 other location - About 3 hrs to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 194..207

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    public function testEnforceHttpsTrueVisitHttpFromSpider()
    {
        foreach ($this->ua_http as $ua) {
            $request = $this->getRequest($ua, false);
            $response = new Response();
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 6 other locations - About 1 hr to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 52..62
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 64..74
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 76..86
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 88..99
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 115..125
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 139..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    public function testEnforceHttpsFalseVisitHttpsFromSpider()
    {
        // TODO: for spider, https => http?
        foreach ($this->ua_http as $ua) {
            $request = $this->getRequest($ua, true);
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 6 other locations - About 1 hr to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 52..62
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 64..74
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 76..86
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 115..125
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 127..137
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 139..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    public function testEnforceHttpsFalseVisitHttpFromBrowser()
    {
        foreach ($this->ua_https as $ua) {
            $request = $this->getRequest($ua, false);
            $response = new Response();
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 6 other locations - About 1 hr to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 64..74
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 76..86
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 88..99
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 115..125
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 127..137
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 139..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    public function testEnforceHttpsFalseVisitHttpFromSpider()
    {
        foreach ($this->ua_http as $ua) {
            $request = $this->getRequest($ua, false);
            $response = new Response();
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 6 other locations - About 1 hr to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 52..62
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 64..74
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 88..99
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 115..125
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 127..137
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 139..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    public function testEnforceHttpsFalseVisitHttpsFromBrowser()
    {
        foreach ($this->ua_https as $ua) {
            $request = $this->getRequest($ua, true);
            $response = new Response();
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 6 other locations - About 1 hr to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 52..62
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 76..86
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 88..99
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 115..125
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 127..137
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 139..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    public function testEnforceHttpsTrueVisitHttpsFromBrowser()
    {
        foreach ($this->ua_https as $ua) {
            $request = $this->getRequest($ua, true);
            $response = new Response();
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 6 other locations - About 1 hr to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 52..62
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 64..74
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 76..86
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 88..99
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 127..137
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 139..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    public function testEnforceHttpsTrueVisitHttpsFromSpider()
    {
        // TODO: for spider, https => http?
        foreach ($this->ua_http as $ua) {
            $request = $this->getRequest($ua, true);
Severity: Major
Found in src/Test/EventListener/HttpsRedirectionServiceTest.php and 6 other locations - About 1 hr to fix
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 52..62
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 64..74
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 76..86
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 88..99
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 115..125
src/Test/EventListener/HttpsRedirectionServiceTest.php on lines 127..137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status