Showing 6 of 6 total issues
Function Order
has 85 lines of code (exceeds 25 allowed). Consider refactoring. Open
function Order(options) {
var self = this;
this.options = options || {};
Function makeRequest
has 72 lines of code (exceeds 25 allowed). Consider refactoring. Open
function makeRequest(options, callback) {
options = options || {};
options.options = options.options || {};
options.context = options.context || {
config: {},
Function post
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
post: function(params, callback) {
var schema = {
order_id: {
description: 'Order ID. If this field is present all other fields are ignored',
type: 'number',
Function post
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
post: function(params, callback) {
var schema = {
notify: {
description:
'Allows disabling of merchant notifications for this order. Notifications must be enabled, and a notification URL configured in your Account settings. 0 – Disabled, 1 – Enabled (Default)',
Similar blocks of code found in 2 locations. Consider refactoring. Open
gulp.task('report-coverage', function() {
return gulp
.src('./coverage/**/lcov.info')
.pipe(debug())
.pipe(coveralls());
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 50.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
gulp.task('report-codacy', function() {
return gulp
.src('./coverage/**/lcov.info')
.pipe(debug())
.pipe(codacy());
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 50.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76