Sign upLogin

vindi/vindi-woocommerce

View on GitHub
Star
src/controllers/ProductController.php

Summary

Maintainability
B
4 hrs
Test Coverage

Showing 71 of 71 total issues

Method create has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function create($post_id, $post, $update, $recreated = false)
  {
        // Check if the post is a draft
        if (strpos(get_post_status($post_id), 'draft') !== false) {
          return;
Severity: Minor
Found in src/controllers/ProductController.php - About 1 hr to fix

    Method update has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function update($post_id)
      {
            $product = wc_get_product($post_id);
     
            // Check if the post is NOT of the subscription type
    Severity: Minor
    Found in src/controllers/ProductController.php - About 1 hr to fix

      Function create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        function create($post_id, $post, $update, $recreated = false)
        {
              // Check if the post is a draft
              if (strpos(get_post_status($post_id), 'draft') !== false) {
                return;
      Severity: Minor
      Found in src/controllers/ProductController.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return $createdProduct;
      Severity: Major
      Found in src/controllers/ProductController.php - About 30 mins to fix

        The method create() has an NPath complexity of 768. The configured NPath complexity threshold is 200.
        Open

          function create($post_id, $post, $update, $recreated = false)
          {
                // Check if the post is a draft
                if (strpos(get_post_status($post_id), 'draft') !== false) {
                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        The method create() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
        Open

          function create($post_id, $post, $update, $recreated = false)
          {
                // Check if the post is a draft
                if (strpos(get_post_status($post_id), 'draft') !== false) {
                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        The method create has a boolean flag argument $recreated, which is a certain sign of a Single Responsibility Principle violation.
        Open

          function create($post_id, $post, $update, $recreated = false)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        The method update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
                  set_transient('vindi_product_message', 'error', 60);
                }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        The method create uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                  } else {
                    set_transient('vindi_product_message', 'error', 60);
                  }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        Avoid unused private fields such as '$types'.
        Open

            private $types;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        Avoid unused parameters such as '$update'.
        Open

          function create($post_id, $post, $update, $recreated = false)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        Avoid unused parameters such as '$post'.
        Open

          function create($post_id, $post, $update, $recreated = false)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        Visibility must be declared on method "trash"
        Open

          function trash($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Blank line found at start of control structure
        Open

                if(empty($vindi_product_id)) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Visibility must be declared on method "update"
        Open

          function update($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Visibility must be declared on method "create"
        Open

          function create($post_id, $post, $update, $recreated = false)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Visibility must be declared on method "untrash"
        Open

          function untrash($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Visibility must be declared on method "__construct"
        Open

          function __construct(VindiSettings $vindi_settings)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line exceeds 120 characters; contains 128 characters
        Open

                if(!$recreated && get_post_status($post_id) != 'publish' || !empty(get_post_meta($post_id, 'vindi_product_id', true))) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 12 spaces, found 10
        Open

                  }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return $this->update($post_id);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 14 spaces, found 12
        Open

                    set_transient('vindi_product_message', 'created', 60);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Multi-line function call not indented correctly; expected 12 spaces but found 10
        Open

                  array(
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          function trash($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 10 spaces, found 8
        Open

                );
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 10 spaces, found 8
        Open

                return $activatedProduct;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 1 space after IF keyword; 0 found
        Open

                if($updatedProduct) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 12 spaces, found 8
        Open

                }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 12 spaces, found 8
        Open

                } else {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          function untrash($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 4 spaces, found 2
        Open

          {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 0 spaces before closing bracket; 1 found
        Open

                    update_post_meta( $post_id, 'vindi_product_id', $createdProduct['id'] );
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 1 space after IF keyword; 0 found
        Open

                if(empty($vindi_product_id)) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Space after opening parenthesis of function call prohibited
        Open

                    update_post_meta( $post_id, 'vindi_product_id', $createdProduct['id'] );
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Multi-line function call not indented correctly; expected 12 spaces but found 10
        Open

                  $vindi_product_id,
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Multi-line function call not indented correctly; expected 12 spaces but found 10
        Open

                  )
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 10 spaces, found 8
        Open

                if($updatedProduct) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 4 spaces, found 2
        Open

          {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return $this->create($post_id, '', '', true);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 10 spaces, found 8
        Open

                return $inactivatedProduct;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          function __construct(VindiSettings $vindi_settings)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 4 spaces, found 2
        Open

          {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 8
        Open

                return $createdProduct;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 14 spaces, found 10
        Open

                  set_transient('vindi_product_message', 'updated', 60);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 4 spaces, found 2
        Open

          {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 1 space after IF keyword; 0 found
        Open

                if(!$recreated && get_post_status($post_id) != 'publish' || !empty(get_post_meta($post_id, 'vindi_product_id', true))) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 12 spaces, found 10
        Open

                  } else {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          function update($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 4 spaces, found 2
        Open

          {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 1 space after IF keyword; 0 found
        Open

                if(empty($vindi_product_id)) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          function create($post_id, $post, $update, $recreated = false)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 16 spaces, found 12
        Open

                    set_transient('vindi_product_message', 'error', 60);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 8
        Open

                return $updatedProduct;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 1 space after IF keyword; 0 found
        Open

                if(empty($vindi_product_id)) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 14 spaces, found 12
        Open

                    update_post_meta( $post_id, 'vindi_product_id', $createdProduct['id'] );
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 16 spaces, found 10
        Open

                  set_transient('vindi_product_message', 'error', 60);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status