Sign upLogin

vindi/vindi-woocommerce

View on GitHub
Star
src/controllers/ProductController.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method create has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function create($post_id, $post, $update, $recreated = false)
  {
        // Check if the post is a draft
        if (strpos(get_post_status($post_id), 'draft') !== false) {
          return;
Severity: Minor
Found in src/controllers/ProductController.php - About 1 hr to fix

    Method update has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function update($post_id)
  {
        $product = wc_get_product($post_id);

        // Check if the post is NOT of the subscription type
    Severity: Minor
    Found in src/controllers/ProductController.php - About 1 hr to fix

      Function create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        function create($post_id, $post, $update, $recreated = false)
  {
        // Check if the post is a draft
        if (strpos(get_post_status($post_id), 'draft') !== false) {
          return;
      Severity: Minor
      Found in src/controllers/ProductController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $createdProduct;
      Severity: Major
      Found in src/controllers/ProductController.php - About 30 mins to fix

        The method create() has an NPath complexity of 768. The configured NPath complexity threshold is 200.
        Open

          function create($post_id, $post, $update, $recreated = false)
  {
        // Check if the post is a draft
        if (strpos(get_post_status($post_id), 'draft') !== false) {
          return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
    function bar() {
        // lots of complicated code
    }
}

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method create() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
        Open

          function create($post_id, $post, $update, $recreated = false)
  {
        // Check if the post is a draft
        if (strpos(get_post_status($post_id), 'draft') !== false) {
          return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The method create has a boolean flag argument $recreated, which is a certain sign of a Single Responsibility Principle violation.
        Open

          function create($post_id, $post, $update, $recreated = false)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method create uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                  } else {
            set_transient('vindi_product_message', 'error', 60);
          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
          set_transient('vindi_product_message', 'error', 60);
        }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid unused parameters such as '$update'.
        Open

          function create($post_id, $post, $update, $recreated = false)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        Avoid unused private fields such as '$types'.
        Open

            private $types;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        UnusedPrivateField

        Since: 0.2

        Detects when a private field is declared and/or assigned a value, but not used.

        Example

        class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

        Avoid unused parameters such as '$post'.
        Open

          function create($post_id, $post, $update, $recreated = false)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpmd

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        Visibility must be declared on method "__construct"
        Open

          function __construct(VindiSettings $vindi_settings)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Visibility must be declared on method "create"
        Open

          function create($post_id, $post, $update, $recreated = false)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Visibility must be declared on method "update"
        Open

          function update($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Blank line found at start of control structure
        Open

                if(empty($vindi_product_id)) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Visibility must be declared on method "trash"
        Open

          function trash($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Visibility must be declared on method "untrash"
        Open

          function untrash($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line exceeds 120 characters; contains 128 characters
        Open

                if(!$recreated && get_post_status($post_id) != 'publish' || !empty(get_post_meta($post_id, 'vindi_product_id', true))) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 4 spaces, found 2
        Open

          {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 1 space after IF keyword; 0 found
        Open

                if(empty($vindi_product_id)) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 16 spaces, found 10
        Open

                  set_transient('vindi_product_message', 'error', 60);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 10 spaces, found 8
        Open

                return $inactivatedProduct;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          function create($post_id, $post, $update, $recreated = false)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 1 space after IF keyword; 0 found
        Open

                if(empty($vindi_product_id)) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          function __construct(VindiSettings $vindi_settings)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          function update($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return $this->create($post_id, '', '', true);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 12 spaces, found 8
        Open

                }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 0 spaces before closing bracket; 1 found
        Open

                    update_post_meta( $post_id, 'vindi_product_id', $createdProduct['id'] );
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 14 spaces, found 12
        Open

                    set_transient('vindi_product_message', 'created', 60);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 10 spaces, found 8
        Open

                return $activatedProduct;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 14 spaces, found 12
        Open

                    update_post_meta( $post_id, 'vindi_product_id', $createdProduct['id'] );
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          function trash($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Multi-line function call not indented correctly; expected 12 spaces but found 10
        Open

                  )
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 4 spaces, found 2
        Open

          {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 12 spaces, found 10
        Open

                  }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 10 spaces, found 8
        Open

                if($updatedProduct) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Space after opening parenthesis of function call prohibited
        Open

                    update_post_meta( $post_id, 'vindi_product_id', $createdProduct['id'] );
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 10 spaces, found 8
        Open

                );
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 1 space after IF keyword; 0 found
        Open

                if($updatedProduct) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 1 space after IF keyword; 0 found
        Open

                if(!$recreated && get_post_status($post_id) != 'publish' || !empty(get_post_meta($post_id, 'vindi_product_id', true))) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 14 spaces, found 10
        Open

                  set_transient('vindi_product_message', 'updated', 60);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 8
        Open

                return $updatedProduct;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          }
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 16 spaces, found 12
        Open

                    set_transient('vindi_product_message', 'error', 60);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return $this->update($post_id);
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 12 spaces, found 10
        Open

                  } else {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Multi-line function call not indented correctly; expected 12 spaces but found 10
        Open

                  $vindi_product_id,
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 4 spaces, found 2
        Open

          {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Multi-line function call not indented correctly; expected 12 spaces but found 10
        Open

                  array(
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 4 spaces, found 2
        Open

          function untrash($post_id)
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 4 spaces, found 2
        Open

          {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 8
        Open

                return $createdProduct;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected 12 spaces, found 8
        Open

                } else {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Expected 1 space after IF keyword; 0 found
        Open

                if(empty($vindi_product_id)) {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 12 spaces, found 10
        Open

                  return;
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        Line indented incorrectly; expected at least 4 spaces, found 2
        Open

          {
        Severity: Minor
        Found in src/controllers/ProductController.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status