Sign upLogin

viney-shih/go-cache

View on GitHub
Star

Showing 6 of 6 total issues

Method factory.NewCache has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func (f *factory) NewCache(settings []Setting) Cache {
    m := map[string]*config{}
    for _, setting := range settings {
        // check prefix
        if setting.Prefix == "" {
Severity: Minor
Found in factory.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method factory.NewCache has 65 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (f *factory) NewCache(settings []Setting) Cache {
    m := map[string]*config{}
    for _, setting := range settings {
        // check prefix
        if setting.Prefix == "" {
Severity: Minor
Found in factory.go - About 1 hr to fix

    Method cache.MGet has 62 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (c *cache) MGet(ctx context.Context, prefix string, keys ...string) (Result, error) {
    cfg, ok := c.configs[prefix]
    if !ok {
        return nil, ErrPfxNotRegistered
    }
    Severity: Minor
    Found in cache.go - About 1 hr to fix

      Method cache.MGet has 9 return statements (exceeds 4 allowed).
      Open

      func (c *cache) MGet(ctx context.Context, prefix string, keys ...string) (Result, error) {
    cfg, ok := c.configs[prefix]
    if !ok {
        return nil, ErrPfxNotRegistered
    }
      Severity: Major
      Found in cache.go - About 55 mins to fix

        Method cache.GetByFunc has 9 return statements (exceeds 4 allowed).
        Open

        func (c *cache) GetByFunc(ctx context.Context, prefix, key string, container interface{}, getter OneTimeGetterFunc) error {
    cfg, ok := c.configs[prefix]
    if !ok {
        return ErrPfxNotRegistered
    }
        Severity: Major
        Found in cache.go - About 55 mins to fix

          Function Unmarshal has 5 return statements (exceeds 4 allowed).
          Open

          func Unmarshal(b []byte, value interface{}) error {
    if len(b) == 0 {
        return nil
    }
          Severity: Major
          Found in marshaler.go - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language