Sign upLogin

vinsol/Spree-Gtpay

View on GitHub
Star

Showing 1 of 1 total issue

Method redirect_to_gtpay has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def redirect_to_gtpay
    if payment_page?
      payment_method = Spree::PaymentMethod.where(:id => (select_gtpay_payment(params[:order][:payments_attributes])[:payment_method_id])).first
      if payment_method.kind_of?(Spree::Gateway::Gtpay)
        if @order.update_attributes(object_params)
Severity: Minor
Found in app/controllers/spree/checkout_controller_decorator.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language