Sign upLogin

visavi/rotor

View on GitHub
Star
app/Http/Controllers/Admin/BanController.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method edit has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function edit(Request $request, Validator $validator)
    {
        $user = User::query()->where('login', $request->input('user'))->with('lastBan')->first();

        if (! $user) {
Severity: Minor
Found in app/Http/Controllers/Admin/BanController.php - About 2 hrs to fix

    Method change has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function change(Request $request, Validator $validator)
    {
        $user = User::query()->where('login', $request->input('user'))->with('lastBan')->first();

        if (! $user) {
    Severity: Minor
    Found in app/Http/Controllers/Admin/BanController.php - About 1 hr to fix

      Function edit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function edit(Request $request, Validator $validator)
    {
        $user = User::query()->where('login', $request->input('user'))->with('lastBan')->first();

        if (! $user) {
      Severity: Minor
      Found in app/Http/Controllers/Admin/BanController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function change has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function change(Request $request, Validator $validator)
    {
        $user = User::query()->where('login', $request->input('user'))->with('lastBan')->first();

        if (! $user) {
      Severity: Minor
      Found in app/Http/Controllers/Admin/BanController.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status