Sign upLogin

visavi/rotor

View on GitHub
Star
app/Http/Controllers/Admin/FileController.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method create has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function create(Request $request, Validator $validator)
    {
        if (! is_writable(resource_path('views/' . $this->path))) {
            abort(200, __('admin.files.directory_not_writable', ['dir' => $this->path]));
        }
Severity: Minor
Found in app/Http/Controllers/Admin/FileController.php - About 1 hr to fix

    Function create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function create(Request $request, Validator $validator)
    {
        if (! is_writable(resource_path('views/' . $this->path))) {
            abort(200, __('admin.files.directory_not_writable', ['dir' => $this->path]));
        }
    Severity: Minor
    Found in app/Http/Controllers/Admin/FileController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method delete has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function delete(Request $request, Validator $validator): RedirectResponse
    {
        if (! is_writable(resource_path('views/' . $this->path))) {
            abort(200, __('admin.files.directory_not_writable', ['dir' => $this->path]));
        }
    Severity: Minor
    Found in app/Http/Controllers/Admin/FileController.php - About 1 hr to fix

      Method edit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function edit(Request $request, Validator $validator)
    {
        $path = $this->path;
        $file = $path ? '/' . $this->file : $this->file;
        $writable = is_writable(resource_path('views/' . $path . $file . '.blade.php'));
      Severity: Minor
      Found in app/Http/Controllers/Admin/FileController.php - About 1 hr to fix

        Function delete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function delete(Request $request, Validator $validator): RedirectResponse
    {
        if (! is_writable(resource_path('views/' . $this->path))) {
            abort(200, __('admin.files.directory_not_writable', ['dir' => $this->path]));
        }
        Severity: Minor
        Found in app/Http/Controllers/Admin/FileController.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function edit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function edit(Request $request, Validator $validator)
    {
        $path = $this->path;
        $file = $path ? '/' . $this->file : $this->file;
        $writable = is_writable(resource_path('views/' . $path . $file . '.blade.php'));
        Severity: Minor
        Found in app/Http/Controllers/Admin/FileController.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status