Sign upLogin

visavi/rotor

View on GitHub
Star
app/Http/Controllers/Admin/ForumController.php

Summary

Maintainability
F
5 days
Test Coverage

File ForumController.php has 391 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace App\Http\Controllers\Admin;
Severity: Minor
Found in app/Http/Controllers/Admin/ForumController.php - About 5 hrs to fix

    Method actionTopic has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionTopic(int $id, Request $request): RedirectResponse
    {
        $page = int($request->input('page', 1));

        /** @var Topic $topic */
    Severity: Minor
    Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

      Method topic has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function topic(int $id): View
    {
        $topic = Topic::query()->where('id', $id)->with('forum.parent')->first();

        if (! $topic) {
      Severity: Minor
      Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

        Method editTopic has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function editTopic(int $id, Request $request, Validator $validator)
    {
        /** @var Topic $topic */
        $topic = Topic::query()->find($id);
        Severity: Minor
        Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

          Method edit has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function edit(int $id, Request $request, Validator $validator)
    {
        if (! isAdmin(User::BOSS)) {
            abort(403, __('errors.forbidden'));
        }
          Severity: Minor
          Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

            Function actionTopic has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function actionTopic(int $id, Request $request): RedirectResponse
    {
        $page = int($request->input('page', 1));

        /** @var Topic $topic */
            Severity: Minor
            Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method moveTopic has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function moveTopic(int $id, Request $request, Validator $validator)
    {
        /** @var Topic $topic */
        $topic = Topic::query()->find($id);
            Severity: Minor
            Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

              Function editTopic has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function editTopic(int $id, Request $request, Validator $validator)
    {
        /** @var Topic $topic */
        $topic = Topic::query()->find($id);
              Severity: Minor
              Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method deleteTopic has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function deleteTopic(int $id, Request $request, Validator $validator): RedirectResponse
    {
        $page = int($request->input('page', 1));

        /** @var Topic $topic */
              Severity: Minor
              Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

                Function edit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function edit(int $id, Request $request, Validator $validator)
    {
        if (! isAdmin(User::BOSS)) {
            abort(403, __('errors.forbidden'));
        }
                Severity: Minor
                Found in app/Http/Controllers/Admin/ForumController.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function moveTopic has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function moveTopic(int $id, Request $request, Validator $validator)
    {
        /** @var Topic $topic */
        $topic = Topic::query()->find($id);
                Severity: Minor
                Found in app/Http/Controllers/Admin/ForumController.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    public function delete(int $id, Request $request, Validator $validator): RedirectResponse
    {
        if (! isAdmin(User::BOSS)) {
            abort(403, __('errors.forbidden'));
        }
                Severity: Major
                Found in app/Http/Controllers/Admin/ForumController.php and 3 other locations - About 1 day to fix
                app/Http/Controllers/Admin/ArticleController.php on lines 119..149
                app/Http/Controllers/Admin/BoardController.php on lines 160..190
                app/Http/Controllers/Admin/LoadController.php on lines 120..150

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 274.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    public function create(Request $request, Validator $validator): RedirectResponse
    {
        if (! isAdmin(User::BOSS)) {
            abort(403, __('errors.forbidden'));
        }
                Severity: Major
                Found in app/Http/Controllers/Admin/ForumController.php and 3 other locations - About 1 day to fix
                app/Http/Controllers/Admin/ArticleController.php on lines 34..63
                app/Http/Controllers/Admin/BoardController.php on lines 71..100
                app/Http/Controllers/Admin/LoadController.php on lines 35..64

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 263.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                    public function restatement(Request $request): RedirectResponse
    {
        if (! isAdmin(User::BOSS)) {
            abort(403, __('errors.forbidden'));
        }
                Severity: Major
                Found in app/Http/Controllers/Admin/ForumController.php and 7 other locations - About 2 hrs to fix
                app/Http/Controllers/Admin/ArticleController.php on lines 154..169
                app/Http/Controllers/Admin/BoardController.php on lines 288..303
                app/Http/Controllers/Admin/LoadController.php on lines 155..170
                app/Http/Controllers/Admin/NewsController.php on lines 158..173
                app/Http/Controllers/Admin/OfferController.php on lines 160..175
                app/Http/Controllers/Admin/PhotoController.php on lines 111..126
                app/Http/Controllers/Admin/VoteController.php on lines 182..197

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 133.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if ($vote->answers->isNotEmpty()) {
                $results = Arr::pluck($vote->answers, 'result', 'answer');
                $max = max($results);

                arsort($results);
                Severity: Major
                Found in app/Http/Controllers/Admin/ForumController.php and 1 other location - About 1 hr to fix
                app/Http/Controllers/Forum/TopicController.php on lines 96..106

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 107.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function end(int $id): RedirectResponse
    {
        /** @var Topic $topic */
        $topic = Topic::query()->find($id);
                Severity: Major
                Found in app/Http/Controllers/Admin/ForumController.php and 1 other location - About 1 hr to fix
                app/Http/Controllers/Forum/TopicController.php on lines 649..661

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status