Sign upLogin

visavi/rotor

View on GitHub
Star
app/Http/Controllers/Admin/NewsController.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method edit has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function edit(int $id, Request $request, Validator $validator)
    {
        /** @var News $news */
        $news = News::query()->find($id);
        $page = int($request->input('page', 1));
Severity: Minor
Found in app/Http/Controllers/Admin/NewsController.php - About 1 hr to fix

    Method create has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function create(Request $request, Validator $validator)
    {
        if ($request->isMethod('post')) {
            $title = $request->input('title');
            $text = $request->input('text');
    Severity: Minor
    Found in app/Http/Controllers/Admin/NewsController.php - About 1 hr to fix

      Function create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function create(Request $request, Validator $validator)
    {
        if ($request->isMethod('post')) {
            $title = $request->input('title');
            $text = $request->input('text');
      Severity: Minor
      Found in app/Http/Controllers/Admin/NewsController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function edit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function edit(int $id, Request $request, Validator $validator)
    {
        /** @var News $news */
        $news = News::query()->find($id);
        $page = int($request->input('page', 1));
      Severity: Minor
      Found in app/Http/Controllers/Admin/NewsController.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function restatement(Request $request): RedirectResponse
    {
        if (! isAdmin(User::BOSS)) {
            abort(403, __('errors.forbidden'));
        }
      Severity: Major
      Found in app/Http/Controllers/Admin/NewsController.php and 7 other locations - About 2 hrs to fix
      app/Http/Controllers/Admin/ArticleController.php on lines 154..169
      app/Http/Controllers/Admin/BoardController.php on lines 288..303
      app/Http/Controllers/Admin/ForumController.php on lines 167..182
      app/Http/Controllers/Admin/LoadController.php on lines 155..170
      app/Http/Controllers/Admin/OfferController.php on lines 160..175
      app/Http/Controllers/Admin/PhotoController.php on lines 111..126
      app/Http/Controllers/Admin/VoteController.php on lines 182..197

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 133.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status