Sign upLogin

visavi/rotor

View on GitHub
Star
app/Http/Controllers/ApiController.php

Summary

Maintainability
D
1 day
Test Coverage

File ApiController.php has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace App\Http\Controllers;
Severity: Minor
Found in app/Http/Controllers/ApiController.php - About 2 hrs to fix

    Method talk has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function talk(string $login, Request $request): Response
    {
        /** @var User $user */
        $user = $request->attributes->get('user');
    Severity: Major
    Found in app/Http/Controllers/ApiController.php - About 2 hrs to fix

      Method dialogues has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function dialogues(Request $request): Response
    {
        /** @var User $user */
        $user = $request->attributes->get('user');
      Severity: Minor
      Found in app/Http/Controllers/ApiController.php - About 1 hr to fix

        Method forums has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function forums(int $id): Response
    {
        /** @var Forum $forum */
        $forum = Forum::query()->find($id);
        Severity: Minor
        Found in app/Http/Controllers/ApiController.php - About 1 hr to fix

          Method user has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function user(Request $request): Response
    {
        /** @var User $user */
        $user = $request->attributes->get('user');
          Severity: Minor
          Found in app/Http/Controllers/ApiController.php - About 1 hr to fix

            Method topics has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function topics(int $id): Response
    {
        /** @var Topic $topic */
        $topic = Topic::query()->find($id);
            Severity: Minor
            Found in app/Http/Controllers/ApiController.php - About 1 hr to fix

              Method users has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function users(string $login): Response
    {
        $user = getUserByLogin($login);

        if (! $user) {
              Severity: Minor
              Found in app/Http/Controllers/ApiController.php - About 1 hr to fix

                Function talk has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function talk(string $login, Request $request): Response
    {
        /** @var User $user */
        $user = $request->attributes->get('user');
                Severity: Minor
                Found in app/Http/Controllers/ApiController.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        return response()->json([
            'success' => true,
            'data'    => $messages,
            'links'   => [
                'next' => $dialogues->nextPageUrl(),
                Severity: Major
                Found in app/Http/Controllers/ApiController.php and 3 other locations - About 45 mins to fix
                app/Http/Controllers/ApiController.php on lines 223..237
                app/Http/Controllers/ApiController.php on lines 277..291
                app/Http/Controllers/ApiController.php on lines 325..339

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 95.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        return response()->json([
            'success' => true,
            'data'    => $data,
            'links'   => [
                'next' => $topics->nextPageUrl(),
                Severity: Major
                Found in app/Http/Controllers/ApiController.php and 3 other locations - About 45 mins to fix
                app/Http/Controllers/ApiController.php on lines 152..166
                app/Http/Controllers/ApiController.php on lines 223..237
                app/Http/Controllers/ApiController.php on lines 325..339

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 95.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        return response()->json([
            'success' => true,
            'data'    => $msg,
            'links'   => [
                'next' => $messages->nextPageUrl(),
                Severity: Major
                Found in app/Http/Controllers/ApiController.php and 3 other locations - About 45 mins to fix
                app/Http/Controllers/ApiController.php on lines 152..166
                app/Http/Controllers/ApiController.php on lines 277..291
                app/Http/Controllers/ApiController.php on lines 325..339

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 95.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        return response()->json([
            'success' => true,
            'data'    => $data,
            'links'   => [
                'next' => $posts->nextPageUrl(),
                Severity: Major
                Found in app/Http/Controllers/ApiController.php and 3 other locations - About 45 mins to fix
                app/Http/Controllers/ApiController.php on lines 152..166
                app/Http/Controllers/ApiController.php on lines 223..237
                app/Http/Controllers/ApiController.php on lines 277..291

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 95.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status