Sign upLogin

visavi/rotor

View on GitHub
Star
app/Http/Controllers/MessageController.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method talk has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function talk(string $login): View
    {
        if (is_numeric($login)) {
            $user = new User();
            $user->id = $login;
Severity: Minor
Found in app/Http/Controllers/MessageController.php - About 1 hr to fix

    Method send has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function send(Request $request, Validator $validator, Flood $flood): RedirectResponse
    {
        $login = $request->input('user');
        $msg = $request->input('msg');
    Severity: Minor
    Found in app/Http/Controllers/MessageController.php - About 1 hr to fix

      Method newMessages has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function newMessages(Request $request): Response
    {
        if (! $request->ajax()) {
            return redirect('/');
        }
      Severity: Minor
      Found in app/Http/Controllers/MessageController.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $validator->equal($request->input('_token'), csrf_token(), ['msg' => __('validator.token')])
            ->length($msg, 5, setting('comment_length'), ['msg' => __('validator.text')])
            ->false($flood->isFlood(), ['msg' => __('validator.flood', ['sec' => $flood->getPeriod()])])
        Severity: Major
        Found in app/Http/Controllers/MessageController.php and 1 other location - About 1 hr to fix
        app/Http/Controllers/GuestbookController.php on lines 40..42

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status