Sign upLogin

visavi/rotor

View on GitHub
Star
app/Http/Controllers/PhotoController.php

Summary

Maintainability
D
2 days
Test Coverage

File PhotoController.php has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace App\Http\Controllers;
Severity: Minor
Found in app/Http/Controllers/PhotoController.php - About 3 hrs to fix

    Method create has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function create(Request $request, Validator $validator, Flood $flood)
    {
        if (! $user = getUser()) {
            abort(403, __('main.not_authorized'));
        }
    Severity: Minor
    Found in app/Http/Controllers/PhotoController.php - About 1 hr to fix

      Method comments has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function comments(int $id, Request $request, Validator $validator, Flood $flood)
    {
        /** @var Photo $photo */
        $photo = Photo::query()->find($id);
      Severity: Minor
      Found in app/Http/Controllers/PhotoController.php - About 1 hr to fix

        Method editComment has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function editComment(int $id, int $cid, Request $request, Validator $validator)
    {
        $page = int($request->input('page', 1));

        if (! $user = getUser()) {
        Severity: Minor
        Found in app/Http/Controllers/PhotoController.php - About 1 hr to fix

          Method edit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function edit(int $id, Request $request, Validator $validator)
    {
        $page = int($request->input('page', 1));

        if (! $user = getUser()) {
          Severity: Minor
          Found in app/Http/Controllers/PhotoController.php - About 1 hr to fix

            Function editComment has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function editComment(int $id, int $cid, Request $request, Validator $validator)
    {
        $page = int($request->input('page', 1));

        if (! $user = getUser()) {
            Severity: Minor
            Found in app/Http/Controllers/PhotoController.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function viewComment(int $id, int $cid): RedirectResponse
    {
        /** @var Photo $photo */
        $photo = Photo::query()->find($id);
            Severity: Major
            Found in app/Http/Controllers/PhotoController.php and 4 other locations - About 3 hrs to fix
            app/Http/Controllers/ArticleController.php on lines 601..618
            app/Http/Controllers/Load/DownController.php on lines 657..674
            app/Http/Controllers/NewsController.php on lines 246..263
            app/Http/Controllers/OfferController.php on lines 324..341

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 147.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        $validator
                ->true($user, __('main.not_authorized'))
                ->equal($request->input('_token'), csrf_token(), __('validator.token'))
                ->length($msg, 5, setting('comment_length'), ['msg' => __('validator.text')])
                ->false($flood->isFlood(), ['msg' => __('validator.flood', ['sec' => $flood->getPeriod()])])
            Severity: Major
            Found in app/Http/Controllers/PhotoController.php and 1 other location - About 1 hr to fix
            app/Http/Controllers/ArticleController.php on lines 287..291

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 118.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function end(int $id): RedirectResponse
    {
        /** @var Photo $photo */
        $photo = Photo::query()->find($id);
            Severity: Major
            Found in app/Http/Controllers/PhotoController.php and 2 other locations - About 1 hr to fix
            app/Http/Controllers/Load/DownController.php on lines 484..498
            app/Http/Controllers/OfferController.php on lines 305..319

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    $photo = Photo::query()
            ->select('photos.*', 'pollings.vote')
            ->where('photos.id', $id)
            ->leftJoin('pollings', static function (JoinClause $join) {
                $join->on('photos.id', 'pollings.relate_id')
            Severity: Major
            Found in app/Http/Controllers/PhotoController.php and 2 other locations - About 55 mins to fix
            app/Http/Controllers/ArticleController.php on lines 72..81
            app/Http/Controllers/Load/DownController.php on lines 30..39

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 98.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status