visavi/rotor

Method userlist has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function userlist(Request $request)
    {
        $type = check($request->input('type', 'users'));
        $sort = check($request->input('sort', 'point'));
        $user = $request->input('user', getUser('login'));

Avoid too many return statements within this method.

Open

        return view('users/users', compact('users', 'user', 'type', 'sort'));

Avoid too many return statements within this method.

Open

                return redirect('users?page=' . $end . '&user=' . $user . '&type=' . $type . '&sort=' . $sort);

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        $users = User::query()
            ->when($type === 'admins', static function (Builder $query) {
                return $query->whereIn('level', User::ADMIN_GROUPS);
            })
            ->when($type === 'birthdays', static function (Builder $query) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            $position = User::query()
                ->when($type === 'admins', static function (Builder $query) {
                    return $query->whereIn('level', User::ADMIN_GROUPS);
                })
                ->when($type === 'birthdays', static function (Builder $query) {

• Read up
  Read up