Sign upLogin

vistart/yii2-models

View on GitHub
Star
traits/EntityQueryTrait.php

Summary

Maintainability
A
0 mins
Test Coverage

The method id has a boolean flag argument $like, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function id($id, $like = false)
Severity: Minor
Found in traits/EntityQueryTrait.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method guid has a boolean flag argument $like, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function guid($guid, $like = false)
Severity: Minor
Found in traits/EntityQueryTrait.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid using short method names like EntityQueryTrait::id(). The configured minimum method name length is 3.
Open

    public function id($id, $like = false)
    {
        $model = $this->noInitModel;
        return $this->likeCondition($id, $model->idAttribute, $like);
    }
Severity: Minor
Found in traits/EntityQueryTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function id($id, $like = false)
Severity: Minor
Found in traits/EntityQueryTrait.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Whitespace found at end of line
Open

     * @param string $start
Severity: Minor
Found in traits/EntityQueryTrait.php by phpcodesniffer

There are no issues that match your filters.

Category
Status