vitaclear/project-lvl1-s220

View on GitHub
src/games/newbalance.js

Summary

Maintainability
C
1 day
Test Coverage

Function balancenum has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

const balancenum = (digit1, digit2, digit3, digit4) => {
  if (isbalanced(digit1, digit2, digit3, digit4)) { return `${digit1}${digit2}${digit3}${digit4}`; }
  if (digit1 === Math.max(digit1, digit2, digit3, digit4)) {
    if (digit4 === Math.min(digit2, digit3, digit4)) {
      return balancenum(digit1 - 1, digit2, digit3, digit4 + 1);
Severity: Minor
Found in src/games/newbalance.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function balancenum has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const balancenum = (digit1, digit2, digit3, digit4) => {
  if (isbalanced(digit1, digit2, digit3, digit4)) { return `${digit1}${digit2}${digit3}${digit4}`; }
  if (digit1 === Math.max(digit1, digit2, digit3, digit4)) {
    if (digit4 === Math.min(digit2, digit3, digit4)) {
      return balancenum(digit1 - 1, digit2, digit3, digit4 + 1);
Severity: Minor
Found in src/games/newbalance.js - About 1 hr to fix

    Function isbalanced has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    const isbalanced = (digit1, digit2, digit3, digit4) => {
      if (digit1 <= digit2) {
        if (digit2 <= digit3) {
          if (digit3 <= digit4) {
            if ((digit4 - digit1) <= 1) {
    Severity: Minor
    Found in src/games/newbalance.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return balancenum(digit1, digit2, digit3 - 1, digit4 + 1);
    Severity: Major
    Found in src/games/newbalance.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return balancenum(digit1, digit2 + 1, digit3, digit4 - 1);
      Severity: Major
      Found in src/games/newbalance.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return balancenum(digit1, digit2 - 1, digit3, digit4 + 1);
        Severity: Major
        Found in src/games/newbalance.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return balancenum(digit1, digit2, digit3 + 1, digit4 - 1);
          Severity: Major
          Found in src/games/newbalance.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return balancenum(digit1 + 1, digit2, digit3 - 1, digit4);
            Severity: Major
            Found in src/games/newbalance.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return balancenum(digit1 + 1, digit2 - 1, digit3, digit4);
              Severity: Major
              Found in src/games/newbalance.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return balancenum(digit1, digit2 + 1, digit3 - 1, digit4);
                Severity: Major
                Found in src/games/newbalance.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return balancenum(digit1 + 1, digit2, digit3, digit4 - 1);
                  Severity: Major
                  Found in src/games/newbalance.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return balancenum(digit1, digit2 - 1, digit3 + 1, digit4);
                    Severity: Major
                    Found in src/games/newbalance.js - About 30 mins to fix

                      There are no issues that match your filters.

                      Category
                      Status