vitaly/debitcredit

View on GitHub

Showing 2 of 2 total issues

Method prevent_overdraft has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def prevent_overdraft
      return unless balance_changed?
      return unless check_overdraft
      return unless balance < 0
      return unless balance_was > balance
Severity: Minor
Found in app/models/debitcredit/account.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_or_create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def find_or_create(name, kind = nil, overdraft = false)

        unless account = find_by(name: name)
          # Note: reference is automatically provided by association
          # when running through an association, e.g. @user.accounts[ .... ]
Severity: Minor
Found in app/models/debitcredit/account.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language