Sign upLogin

vladcalin/gemstone

View on GitHub
Star
gemstone/core/handlers.py

Summary

Maintainability
C
1 day
Test Coverage

Function post has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    def post(self):
        if self.request.headers.get("Content-type").split(";")[0] != "application/json":
            self.write_single_response(GenericResponse.INVALID_REQUEST)
            return
Severity: Minor
Found in gemstone/core/handlers.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handle_single_request has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def handle_single_request(self, request_object):
        """
        Handles a single request object and returns the correct result as follows:

        - A valid response object if it is a regular request (with ID)
Severity: Minor
Found in gemstone/core/handlers.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prepare_method_call has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def prepare_method_call(self, method, args):
        """
        Wraps a method so that method() will call ``method(*args)`` or ``method(**args)``,
        depending of args type
Severity: Minor
Found in gemstone/core/handlers.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return err
Severity: Major
Found in gemstone/core/handlers.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return to_return_resp
    Severity: Major
    Found in gemstone/core/handlers.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                          return resp
      Severity: Major
      Found in gemstone/core/handlers.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return resp
        Severity: Major
        Found in gemstone/core/handlers.py - About 30 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if not isinstance(response_obj, JsonRpcResponse):
            raise ValueError(
                "Expected JsonRpcResponse, but got {} instead".format(type(response_obj).__name__))
          Severity: Minor
          Found in gemstone/core/handlers.py and 2 other locations - About 30 mins to fix
          gemstone/core/structs.py on lines 168..170
          gemstone/core/structs.py on lines 203..204

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status