Sign upLogin

voltrb/volt

View on GitHub
Star

Showing 336 of 336 total issues

Method closed has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def closed
      unless @closed
        @closed = true
        # Remove ourself from the available channels
        @@channels.delete(self)
Severity: Minor
Found in lib/volt/server/socket_connection_handler.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method remove has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def remove(*args)
      stack   = []
      section = @pool

      args.each_with_index do |arg, index|
Severity: Minor
Found in lib/volt/utils/generic_pool.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def self.validate(model, field_name, args)
      errors = {}
      value  = model.get(field_name)

      if args.is_a?(Array)
Severity: Minor
Found in lib/volt/models/validators/inclusion_validator.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cweek_cyear has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def cweek_cyear
    jan01 = Time.new(self.year, 1, 1)
    jan01_wday = jan01.wday
    first_monday = 0
    year = self.year
Severity: Minor
Found in lib/volt/utils/time_opal_patch.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_attribute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def process_attribute(tag_name, attributes, attribute_name, value)
      parts, binding_count = binding_parts_and_count(value)

      # if this attribute has bindings
      if binding_count > 0
Severity: Minor
Found in lib/volt/server/html_parser/attribute_scope.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_by_tag_id has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def find_by_tag_id(tag_id)
      @nodes.each do |node|
        if node.is_a?(ComponentNode)
          # Walk down nodes
          val = node.find_by_tag_id(tag_id)
Severity: Minor
Found in lib/volt/page/targets/binding_document/component_node.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function access has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    access: function( elems, fn, key, value, chainable, emptyGet, raw ) {
Severity: Major
Found in app/volt/assets/js/jquery-2.0.3.js - About 50 mins to fix

    Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def initialize(volt_app, target, context, binding_name, binding_in_path, getter, content_template_path = nil)
    Severity: Major
    Found in lib/volt/page/bindings/view_binding.rb - About 50 mins to fix

      Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def initialize(volt_app, target, context, binding_name, attribute_name, getter, setter)
      Severity: Major
      Found in lib/volt/page/bindings/attribute_binding.rb - About 50 mins to fix

        Method local has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def self.local(year, month = nil, day = nil, hour = nil, min = nil, sec = nil, millisecond = nil)
        Severity: Major
        Found in lib/volt/utils/time_opal_patch.rb - About 50 mins to fix

          Method new has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def self.new(year = undefined, month = nil, day = nil, hour = nil, min = nil, sec = nil, utc_offset = nil)
          Severity: Major
          Found in lib/volt/utils/time_opal_patch.rb - About 50 mins to fix

            Method gm has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def self.gm(year, month = nil, day = nil, hour = nil, min = nil, sec = nil, millisecond = nil)
            Severity: Major
            Found in lib/volt/utils/time_opal_patch.rb - About 50 mins to fix

              Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def initialize(zone = nil, year = nil, month = nil, day = nil, hour = nil, min = nil, sec = nil)
              Severity: Major
              Found in lib/volt/helpers/time/volt_time.rb - About 50 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    $.fn.watch = function () {
      Array.prototype.unshift.call(arguments, this);
      return _watch.apply(this, arguments);
    };
                Severity: Minor
                Found in app/volt/assets/js/volt_watch.js and 1 other location - About 50 mins to fix
                app/volt/assets/js/volt_watch.js on lines 211..214

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    $.fn.unwatch = function () {
      Array.prototype.unshift.call(arguments, this);
      return _unwatch.apply(this, arguments);
    };
                Severity: Minor
                Found in app/volt/assets/js/volt_watch.js and 1 other location - About 50 mins to fix
                app/volt/assets/js/volt_watch.js on lines 206..209

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid deeply nested control flow statements.
                Open

                                    if ( copyIsArray ) {
                        copyIsArray = false;
                        clone = src && jQuery.isArray(src) ? src : [];

                    } else {
                Severity: Major
                Found in app/volt/assets/js/jquery-2.0.3.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          for ( match in context ) {
                            // Properties of context are called as methods if possible
                            if ( jQuery.isFunction( this[ match ] ) ) {
                                this[ match ]( context[ match ] );
                  Severity: Major
                  Found in app/volt/assets/js/jquery-2.0.3.js - About 45 mins to fix

                    Method remove has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def remove
      # Unbind events, leave the element there since attribute bindings
      # aren't responsible for it being there.
      case @attribute_name
        when 'value'
                    Severity: Minor
                    Found in lib/volt/page/bindings/attribute_binding.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                        if ( (seed = find(
                        token.matches[0].replace( runescape, funescape ),
                        rsibling.test( tokens[0].type ) && context.parentNode || context
                    )) ) {
                    Severity: Major
                    Found in app/volt/assets/js/jquery-2.0.3.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                      if ( ( ofType ? node.nodeName.toLowerCase() === name : node.nodeType === 1 ) && ++diff ) {
                                    // Cache the index of each encountered element
                                    if ( useCache ) {
                                        (node[ expando ] || (node[ expando ] = {}))[ type ] = [ dirruns, diff ];
                                    }
                      Severity: Major
                      Found in app/volt/assets/js/jquery-2.0.3.js - About 45 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language