Sign upLogin

voltrb/volt

View on GitHub
Star
lib/volt/utils/read_write_lock.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method acquire_write_lock has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def acquire_write_lock
    loop do
      c = @counter.value
      fail 'Too many writers!' if (c & MAX_WRITERS) == MAX_WRITERS
Severity: Minor
Found in lib/volt/utils/read_write_lock.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method acquire_read_lock has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def acquire_read_lock
    loop do
      c = @counter.value
      fail 'Too many reader threads!' if (c & MAX_READERS) == MAX_READERS
Severity: Minor
Found in lib/volt/utils/read_write_lock.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method release_read_lock has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def release_read_lock
    loop do
      c = @counter.value
      if @counter.compare_and_swap(c, c - 1)
        # If one or more writers were waiting, and we were the last reader, wake a writer up
Severity: Minor
Found in lib/volt/utils/read_write_lock.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method release_write_lock has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def release_write_lock
    loop do
      c = @counter.value
      if @counter.compare_and_swap(c, c - RUNNING_WRITER)
        @reader_mutex.synchronize { @reader_q.broadcast }
Severity: Minor
Found in lib/volt/utils/read_write_lock.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status