Sign upLogin

voucherifyio/voucherify-ruby-sdk

View on GitHub
Star

Showing 5 of 9 total issues

Class Client has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client
    attr_reader :backend_url

    def initialize (options)
      @options = options
Severity: Minor
Found in lib/voucherify/client.rb - About 2 hrs to fix

    Method calculate_price has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.calculate_price(base_price, voucher, unit_price = nil)
      e = 100.0

      if voucher[:gift]
        discount = [voucher[:gift][:balance] / e, base_price].min
    Severity: Minor
    Found in lib/voucherify/utils.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method calculate_discount has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.calculate_discount(base_price, voucher, unit_price = nil)
      e = 100.0

      if voucher[:gift]
        discount = [voucher[:gift][:balance] / e, base_price].min
    Severity: Minor
    Found in lib/voucherify/utils.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method calculate_price has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.calculate_price(base_price, voucher, unit_price = nil)
      e = 100.0

      if voucher[:gift]
        discount = [voucher[:gift][:balance] / e, base_price].min
    Severity: Minor
    Found in lib/voucherify/utils.rb - About 1 hr to fix

      Method calculate_discount has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.calculate_discount(base_price, voucher, unit_price = nil)
      e = 100.0

      if voucher[:gift]
        discount = [voucher[:gift][:balance] / e, base_price].min
      Severity: Minor
      Found in lib/voucherify/utils.rb - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language