Sign upLogin

voxable-labs/expando

View on GitHub
Star
lib/expando/api_ai/objects/intent.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method user_says_value has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def user_says_value(existing_params)
      additional_params = Set.new(existing_params)

      new_user_says = processed_utterances.collect do |utterance|
        # If an entity is referenced on this line...
Severity: Minor
Found in lib/expando/api_ai/objects/intent.rb - About 1 hr to fix

Method user_says_value has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def user_says_value(existing_params)
      additional_params = Set.new(existing_params)

      new_user_says = processed_utterances.collect do |utterance|
        # If an entity is referenced on this line...
Severity: Minor
Found in lib/expando/api_ai/objects/intent.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

            # TODO: Make this an option
Severity: Minor
Found in lib/expando/api_ai/objects/intent.rb by fixme

TODO found
Open

      # TODO: needs an exception class
Severity: Minor
Found in lib/expando/api_ai/objects/intent.rb by fixme

TODO found
Open

        # TODO: High - throw an error if none.
Severity: Minor
Found in lib/expando/api_ai/objects/intent.rb by fixme

TODO found
Open

    # TODO: High- document, test, and decompose
Severity: Minor
Found in lib/expando/api_ai/objects/intent.rb by fixme

There are no issues that match your filters.

Category
Status