Sign upLogin

voxgig/seneca-entity-util

View on GitHub
Star

Showing 16 of 18 total issues

Function entity_util has a Cognitive Complexity of 72 (exceeds 5 allowed). Consider refactoring.
Open

function entity_util(options: any) {
  const seneca = this
  const Joi = seneca.util.Joi
  const rtag = seneca.util.Nid({ length: options.rtag.len })
Severity: Minor
Found in entity-util.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File entity-util.js has 292 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* Copyright (c) 2019-2022 voxgig and other contributors, MIT License */
/* $lab:coverage:off$ */
'use strict';
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
Severity: Minor
Found in entity-util.js - About 3 hrs to fix

    Function resolve_rtag has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function resolve_rtag(msg) {
        return __awaiter(this, void 0, void 0, function* () {
            const seneca = this;
            const space = msg.space;
            const key = msg.key;
    Severity: Major
    Found in entity-util.js - About 2 hrs to fix

      Function resolve_rtag has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async function resolve_rtag(msg: any) {
    const seneca = this

    const space = msg.space
    const key = msg.key
      Severity: Major
      Found in entity-util.ts - About 2 hrs to fix

        File entity-util.ts has 268 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /* Copyright (c) 2019-2022 voxgig and other contributors, MIT License */
/* $lab:coverage:off$ */
'use strict'

/* $lab:coverage:on$ */
        Severity: Minor
        Found in entity-util.ts - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function cmd_list_util(msg, meta) {
        return __awaiter(this, void 0, void 0, function* () {
            var start = Date.now();
            var out = yield this.prior(msg);
            intern.apply_duration(out, meta, start, options);
          Severity: Major
          Found in entity-util.js and 1 other location - About 2 hrs to fix
          entity-util.js on lines 154..161

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function cmd_load_util(msg, meta) {
        return __awaiter(this, void 0, void 0, function* () {
            var start = Date.now();
            var out = yield this.prior(msg);
            intern.apply_duration(out, meta, start, options);
          Severity: Major
          Found in entity-util.js and 1 other location - About 2 hrs to fix
          entity-util.js on lines 162..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            async function cmd_list_util(msg: any, meta: any) {
    var start = Date.now()

    var out = await this.prior(msg)
    intern.apply_duration(out, meta, start, options)
          Severity: Major
          Found in entity-util.ts and 1 other location - About 1 hr to fix
          entity-util.ts on lines 183..189

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            async function cmd_load_util(msg: any, meta: any) {
    var start = Date.now()

    var out = await this.prior(msg)
    intern.apply_duration(out, meta, start, options)
          Severity: Major
          Found in entity-util.ts and 1 other location - About 1 hr to fix
          entity-util.ts on lines 191..197

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function cmd_save_util has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function cmd_save_util(msg, meta) {
        return __awaiter(this, void 0, void 0, function* () {
            const start = Date.now();
            const ent = msg.ent;
            if (options.rtag.active) {
          Severity: Minor
          Found in entity-util.js - About 1 hr to fix

            Function cmd_save_util has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              async function cmd_save_util(msg: any, meta: any) {
    const start = Date.now()
    const ent = msg.ent

    if (options.rtag.active) {
            Severity: Minor
            Found in entity-util.ts - About 1 hr to fix

              Function cmd_remove_util has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function cmd_remove_util(msg, meta) {
        return __awaiter(this, void 0, void 0, function* () {
            var start = Date.now();
            // TODO: only supports id-based remove
            if (options.archive.active) {
              Severity: Minor
              Found in entity-util.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        ; (stats.rtag.space[space] = stats.rtag.space[space] || {
          hit: 0,
          miss: 0,
        }).miss++
                Severity: Minor
                Found in entity-util.ts and 1 other location - About 50 mins to fix
                entity-util.ts on lines 268..271

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                (stats.rtag.space[space] = stats.rtag.space[space] || {
                    hit: 0,
                    miss: 0,
                }).miss++;
                Severity: Minor
                Found in entity-util.js and 1 other location - About 50 mins to fix
                entity-util.js on lines 226..229

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                (stats.rtag.space[space] = stats.rtag.space[space] || {
                    hit: 0,
                    miss: 0,
                }).hit++;
                Severity: Minor
                Found in entity-util.js and 1 other location - About 50 mins to fix
                entity-util.js on lines 236..239

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        ; (stats.rtag.space[space] = stats.rtag.space[space] || {
          hit: 0,
          miss: 0,
        }).hit++
                Severity: Minor
                Found in entity-util.ts and 1 other location - About 50 mins to fix
                entity-util.ts on lines 279..282

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language