Sign upLogin

voxgig/seneca-msg-test

View on GitHub
Star

Showing 12 of 12 total issues

Function run has 144 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  run: async function(seneca: any, spec: any, calls: any) {
    let callmap = spec.context

    return new Promise((resolve: any, reject: any) => {
      next_call(0, function(err: any) {
Severity: Major
Found in src/msg-test.ts - About 5 hrs to fix

    Function next_call has 132 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function next_call(call_index: any, done: any): any {
      try {
        if (calls.length <= call_index) {
          return done()
        }
    Severity: Major
    Found in src/msg-test.ts - About 5 hrs to fix

      File msg-test.ts has 296 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* Copyright (c) 2018-2024 Voxgig and other contributors, MIT License */
'use strict'

// TODO: add line numbers to all fail msgs!
      Severity: Minor
      Found in src/msg-test.ts - About 3 hrs to fix

        Function run has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

          run: async function(seneca: any, spec: any, calls: any) {
    let callmap = spec.context

    return new Promise((resolve: any, reject: any) => {
      next_call(0, function(err: any) {
        Severity: Minor
        Found in src/msg-test.ts - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function msg_test has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        function msg_test(seneca: any, spec: any) {
  // Seneca instance is optional
  if (seneca && !seneca.seneca) {
    spec = seneca
    seneca = null
        Severity: Minor
        Found in src/msg-test.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function msg_test has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function msg_test(seneca: any, spec: any) {
  // Seneca instance is optional
  if (seneca && !seneca.seneca) {
    spec = seneca
    seneca = null
        Severity: Minor
        Found in src/msg-test.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    if (call.name) {
            callmap[call.name] = {
              top_pattern: spec.pattern,
              pattern: call.pattern,
              params: params,
          Severity: Major
          Found in src/msg-test.ts and 1 other location - About 1 hr to fix
          src/msg-test.ts on lines 265..275

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    if (call.name) {
            callmap[call.name] = {
              top_pattern: spec.pattern,
              pattern: call.pattern,
              params: params,
          Severity: Major
          Found in src/msg-test.ts and 1 other location - About 1 hr to fix
          src/msg-test.ts on lines 172..182

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function handle_delegate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            handle_delegate: function(instance: any, call: any, callmap: any, spec: any) {
    if (call.delegate) {
      if ('string' === typeof call.delegate) {
        instance = spec.delegates[call.delegate]
          Severity: Minor
          Found in src/msg-test.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                          return done(
                  new Error(
                    'Output for: ' +
                    errname +
                    (call.line ? ' (' + call.line + ')' : '') +
          Severity: Major
          Found in src/msg-test.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                          return done(
                new Error('Output expected for: ' + errname + ', was null')
              )
            Severity: Major
            Found in src/msg-test.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                            return done(
                new Error(
                  'Verify of: ' +
                  errname +
                  ' failed: ' +
              Severity: Major
              Found in src/msg-test.ts - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language