Sign upLogin

voxpupuli/puppet_webhook

View on GitHub
Star
lib/puppet_webhook/parsers/payload.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method branch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Wontfix

      def branch
        case @vcs
        when 'github'
          if @data.key? 'ref'
            @data['ref'].sub('refs/heads/', '')
Severity: Minor
Found in lib/puppet_webhook/parsers/payload.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return 'tfs'              if tfs_webhook?
Severity: Major
Found in lib/puppet_webhook/parsers/payload.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Confirmed

            return 'stash'            if stash_webhook?
    Severity: Major
    Found in lib/puppet_webhook/parsers/payload.rb - About 30 mins to fix

      Method detect_vcs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Confirmed

            def detect_vcs
        return 'github'           if github_webhook?
        return 'gitlab'           if gitlab_webhook?
        return 'bitbucket-server' if bitbucket_server_webhook?
        return 'bitbucket'        if bitbucket_webhook?
      Severity: Minor
      Found in lib/puppet_webhook/parsers/payload.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status