voyager-admin/voyager

View on GitHub
src/Http/Controllers/BreadController.php

Summary

Maintainability
D
2 days
Test Coverage
F
57%

File BreadController.php has 376 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Voyager\Admin\Http\Controllers;

use DB;
Severity: Minor
Found in src/Http/Controllers/BreadController.php - About 5 hrs to fix

    Method relationship has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function relationship(Request $request): array
        {
            // TODO: Validate that the method exists in edit/add layout
            $bread = $this->getBread($request, true);
            list($perPage, $query, $method, $column) = array_values($request->only(['perPage', 'query', 'method', 'column', 'key']));
    Severity: Major
    Found in src/Http/Controllers/BreadController.php - About 3 hrs to fix

      Function relationship has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function relationship(Request $request): array
          {
              // TODO: Validate that the method exists in edit/add layout
              $bread = $this->getBread($request, true);
              list($perPage, $query, $method, $column) = array_values($request->only(['perPage', 'query', 'method', 'column', 'key']));
      Severity: Minor
      Found in src/Http/Controllers/BreadController.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method data has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function data(Request $request): array
          {
              $start = microtime(true);
              $bread = $this->getBread($request);
              $forcedLayout = $request->get('forcedLayout', null);
      Severity: Minor
      Found in src/Http/Controllers/BreadController.php - About 1 hr to fix

        Method edit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function edit(Request $request, mixed $id): InertiaResponse
            {
                $bread = $this->getBread($request, true);
                $layout = $this->breadmanager->getLayoutForAction($bread, 'edit');
        
        
        Severity: Minor
        Found in src/Http/Controllers/BreadController.php - About 1 hr to fix

          Method read has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function read(Request $request, mixed $id): InertiaResponse
              {
                  $bread = $this->getBread($request, true);
                  $layout = $this->breadmanager->getLayoutForAction($bread, 'read');
          
          
          Severity: Minor
          Found in src/Http/Controllers/BreadController.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                        return [
                            'key' => $key,
                            'value' => $translatable ? VoyagerFacade::translate($value) : $value
                        ];
            Severity: Major
            Found in src/Http/Controllers/BreadController.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $item->{$column};
              Severity: Major
              Found in src/Http/Controllers/BreadController.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return true;
                Severity: Major
                Found in src/Http/Controllers/BreadController.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return [
                                  'key'       => $item->getKey(),
                                  'value'     => $translatable ? VoyagerFacade::translate($item->{$column}) : $item->{$column},
                              ];
                  Severity: Major
                  Found in src/Http/Controllers/BreadController.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return [
                                'pages'     => ceil($count / $perPage),
                                'data'      => $data->values(),
                                'selected'  => $selected->values()
                            ];
                    Severity: Major
                    Found in src/Http/Controllers/BreadController.php - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if ($formfield->translatable ?? false) {
                                      $translations = [];
                                      $value = json_decode($value) ?? [];
                                      foreach ($value as $locale => $translated) {
                                          $translations[$locale] = $formfield->read($translated);
                      Severity: Major
                      Found in src/Http/Controllers/BreadController.php and 1 other location - About 1 hr to fix
                      src/Http/Controllers/BreadController.php on lines 252..261

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 105.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if ($formfield->translatable ?? false) {
                                      $translations = [];
                                      $value = json_decode($value) ?? [];
                                      foreach ($value as $locale => $translated) {
                                          $translations[$locale] = $formfield->edit($translated);
                      Severity: Major
                      Found in src/Http/Controllers/BreadController.php and 1 other location - About 1 hr to fix
                      src/Http/Controllers/BreadController.php on lines 205..214

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 105.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status