Sign upLogin

voyager-admin/voyager

View on GitHub
Star
src/VoyagerServiceProvider.php

Summary

Maintainability
D
2 days
Test Coverage
A
95%

File VoyagerServiceProvider.php has 316 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Voyager\Admin;

use Illuminate\Contracts\Auth\Access\Gate;
Severity: Minor
Found in src/VoyagerServiceProvider.php - About 3 hrs to fix

    Method boot has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function boot(Router $router): void
    {
        $router->aliasMiddleware('voyager.admin', VoyagerAdminMiddleware::class);

        $this->registerResources();
    Severity: Minor
    Found in src/VoyagerServiceProvider.php - About 1 hr to fix

      Method registerActions has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function registerActions()
    {
        $breadmanager = $this->breadmanager;

        $read_action = (new Action('voyager::generic.read', 'book-open', null, 'accent'))
      Severity: Minor
      Found in src/VoyagerServiceProvider.php - About 1 hr to fix

        Method registerBulkActions has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function registerBulkActions()
    {
        $breadmanager = $this->breadmanager;

        $add_action = (new Action('voyager::generic.add_type', 'plus', null, 'green'))
        Severity: Minor
        Found in src/VoyagerServiceProvider.php - About 1 hr to fix

          Method register has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function register()
    {
        app()->register(\Inertia\ServiceProvider::class);

        $loader = AliasLoader::getInstance();
          Severity: Minor
          Found in src/VoyagerServiceProvider.php - About 1 hr to fix

            Function boot has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function boot(Router $router): void
    {
        $router->aliasMiddleware('voyager.admin', VoyagerAdminMiddleware::class);

        $this->registerResources();
            Severity: Minor
            Found in src/VoyagerServiceProvider.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                        return 'voyager.'.$bread->slug.'.delete';
            Severity: Major
            Found in src/VoyagerServiceProvider.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return 'voyager.'.$bread->slug.'.restore';
              Severity: Major
              Found in src/VoyagerServiceProvider.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return new Voyager($this->breadmanager, $this->menumanager, $this->pluginmanager, $this->settingmanager);
                Severity: Major
                Found in src/VoyagerServiceProvider.php - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $delete_action = (new Action('voyager::generic.delete', 'trash', null, 'red'))
        ->route(function ($bread) {
            return 'voyager.'.$bread->slug.'.delete';
        })
        ->method('delete')
                  Severity: Major
                  Found in src/VoyagerServiceProvider.php and 1 other location - About 1 hr to fix
                  src/VoyagerServiceProvider.php on lines 242..251

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 101.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $restore_action = (new Action('voyager::generic.restore', 'trash', null, 'yellow'))
        ->route(function ($bread) {
            return 'voyager.'.$bread->slug.'.restore';
        })
        ->method('patch')
                  Severity: Major
                  Found in src/VoyagerServiceProvider.php and 1 other location - About 1 hr to fix
                  src/VoyagerServiceProvider.php on lines 231..240

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 101.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $restore_action = (new Action('voyager::bread.restore_type', 'trash', null, 'yellow'))
        ->route(function ($bread) {
            return 'voyager.'.$bread->slug.'.restore';
        })
        ->method('patch')
                  Severity: Minor
                  Found in src/VoyagerServiceProvider.php and 1 other location - About 55 mins to fix
                  src/VoyagerServiceProvider.php on lines 277..286

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $delete_action = (new Action('voyager::bread.delete_type', 'trash', null, 'red'))
        ->route(function ($bread) {
            return 'voyager.'.$bread->slug.'.delete';
        })
        ->method('delete')
                  Severity: Minor
                  Found in src/VoyagerServiceProvider.php and 1 other location - About 55 mins to fix
                  src/VoyagerServiceProvider.php on lines 288..297

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $edit_action = (new Action('voyager::generic.edit', 'pencil', null, 'yellow'))
        ->route(function ($bread) {
            return 'voyager.'.$bread->slug.'.edit';
        })->permission('edit')
        ->displayOnBread(function ($bread) use ($breadmanager) {
                  Severity: Minor
                  Found in src/VoyagerServiceProvider.php and 1 other location - About 45 mins to fix
                  src/VoyagerServiceProvider.php on lines 215..221

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 95.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $read_action = (new Action('voyager::generic.read', 'book-open', null, 'accent'))
        ->route(function ($bread) {
            return 'voyager.'.$bread->slug.'.read';
        })->permission('read')
        ->displayOnBread(function ($bread) use ($breadmanager) {
                  Severity: Minor
                  Found in src/VoyagerServiceProvider.php and 1 other location - About 45 mins to fix
                  src/VoyagerServiceProvider.php on lines 223..229

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 95.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status