Sign upLogin

vpietri/magento2-developer-quickdevbar

View on GitHub
Star

Showing 185 of 185 total issues

Function pullData has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    public function pullData()
    {
        if ($this->pluginsByTypes === null) {
            $this->pluginsByTypes =  [];
Severity: Minor
Found in Service/Plugin.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute()
    {

        $error = false;
        $output = '';
Severity: Minor
Found in Controller/Action/ConfigUpdate.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Data has 28 functions (exceeds 20 allowed). Consider refactoring.
Open

class Data extends \Magento\Framework\App\Helper\AbstractHelper
{


    /**
Severity: Minor
Found in Helper/Data.php - About 3 hrs to fix

    The class Data has an overall complexity of 77 which is very high. The configured complexity threshold is 50.
    Open

    class Data extends \Magento\Framework\App\Helper\AbstractHelper
{


    /**
    Severity: Minor
    Found in Helper/Data.php by phpmd

    Function initSqlProfilerData has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function initSqlProfilerData()
    {
        $longestQueryTime = 0;
        $shortestQueryTime = 100000;
        $longestQuery = '';
    Severity: Minor
    Found in Service/Sql.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method execute has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute()
    {

        $error = false;
        $output = '';
    Severity: Major
    Found in Controller/Action/ConfigUpdate.php - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
namespace ADM\QuickDevBar\Plugin\Framework\App;

use Magento\Framework\App\CacheInterface;
      Severity: Major
      Found in Plugin/Framework/App/Cache.php and 1 other location - About 2 hrs to fix
      Plugin/PageCache/FrontController/BuiltinPlugin.php on lines 1..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php


namespace ADM\QuickDevBar\Plugin\PageCache\FrontController;
      Severity: Major
      Found in Plugin/PageCache/FrontController/BuiltinPlugin.php and 1 other location - About 2 hrs to fix
      Plugin/Framework/App/Cache.php on lines 1..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File Data.php has 281 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
namespace ADM\QuickDevBar\Helper;

use Magento\Customer\Model\Session;
use Magento\Framework\App\Config\ScopeConfigInterface;
      Severity: Minor
      Found in Helper/Data.php - About 2 hrs to fix

        Panel has 21 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Panel extends \Magento\Framework\View\Element\Template
{
    protected $_mainTabs;
    protected $_frontUrl;
        Severity: Minor
        Found in Block/Tab/Panel.php - About 2 hrs to fix

          Method initSqlProfilerData has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function initSqlProfilerData()
    {
        $longestQueryTime = 0;
        $shortestQueryTime = 100000;
        $longestQuery = '';
          Severity: Major
          Found in Service/Sql.php - About 2 hrs to fix

            Function getHtmlBlocksHierarchy has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getHtmlBlocksHierarchy($treeBlocks = [], $level = 0)
    {
        if (empty($treeBlocks)) {
            $treeBlocks = [$this->qdbHelperRegister->getLayoutHierarchy()];
        }
            Severity: Minor
            Found in Block/Tab/Content/Layout.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getWrapperContent has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getWrapperContent($ajax = false)
    {
//Clean old files
//        /** @var \SplFileInfo $fileInfo */
//        foreach (new \DirectoryIterator($this->getQdbTempDir()) as $fileInfo) {
            Severity: Minor
            Found in Helper/Data.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function buildTreeBlocks has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function buildTreeBlocks($layout, $name = 'root', $alias = '')
    {
        $element = $this->getElementByName($name);
        if ($element) {
            $treeBlocks = [
            Severity: Minor
            Found in Observer/LayoutGenerateBlocksAfterObserver.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function trace has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function trace(array $trace=[], $skipLine = null)
    {
        if(empty($trace)) {
            $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
            is_null($skipLine) && $skipLine=1;
            Severity: Minor
            Found in Helper/Debug.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 14 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    DesignInterface $viewDesign,
        FrontendInterface $cache,
        ViewFileSystem $viewFileSystem,
        ModuleList $moduleList,
        Reader $modulesReader,
            Severity: Major
            Found in Helper/Translate.php - About 1 hr to fix

              Function load has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      load: function( index, event ) {
            index = this._getIndex( index );
            let that = this,
                tab = this.tabs.eq( index ),
                anchor = tab.find( ".ui-tabs-anchor" ),
              Severity: Minor
              Found in view/base/web/js/quickdevbar.js - About 1 hr to fix

                Avoid excessively long class names like ControllerFrontSendResponseBeforeObserver. Keep class name length under 40.
                Open

                class ControllerFrontSendResponseBeforeObserver implements ObserverInterface
{
    /**
     * @var \ADM\QuickDevBar\Helper\Register
     */
                Severity: Minor
                Found in Observer/ControllerFrontSendResponseBeforeObserver.php by phpmd

                LongClassName

                Since: 2.9

                Detects when classes or interfaces are declared with excessively long names.

                Example

                class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

                Source https://phpmd.org/rules/naming.html#longclassname

                Avoid excessively long variable names like $_resultForwardFactory. Keep variable name length under 20.
                Open

                    protected $_resultForwardFactory;
                Severity: Minor
                Found in Controller/Action/ConfigUpdate.php by phpmd

                LongVariable

                Since: 0.2

                Detects when a field, formal or local variable is declared with a long name.

                Example

                class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                Source https://phpmd.org/rules/naming.html#longvariable

                Avoid excessively long variable names like $getTreeBlocksHierarchy. Keep variable name length under 20.
                Open

                    public function addLayoutHierarchy(array $getTreeBlocksHierarchy)
                Severity: Minor
                Found in Service/Layout/Hierarchy.php by phpmd

                LongVariable

                Since: 0.2

                Detects when a field, formal or local variable is declared with a long name.

                Example

                class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                Source https://phpmd.org/rules/naming.html#longvariable

                Severity
                Category
                Status
                Source
                Language