vpoulailleau/python-dev-tools

View on GitHub
python_dev_tools/whataformatter.py

Summary

Maintainability
A
25 mins
Test Coverage
B
89%

subprocess call - check for execution of untrusted input.
Open

                subprocess.run(  # noqa: S603
                    [config.path, *config.cli_args, copy_file],
                    capture_output=True,
                    timeout=10,
                    encoding="utf-8",
Severity: Info
Found in python_dev_tools/whataformatter.py by bandit

Consider possible security implications associated with subprocess module.
Open

import subprocess  # noqa: S404
Severity: Info
Found in python_dev_tools/whataformatter.py by bandit

Function format_file has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def format_file(filepath: str, target_version: str) -> None:
    """Format the file with known formatters.

    Args:
        filepath (str): path of the file to format
Severity: Minor
Found in python_dev_tools/whataformatter.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line too long (82 > 79 characters)
Open

    FormatterConfig(name="pyupgrade", path="pyupgrade", cli_args=["--py37-plus"]),
Severity: Minor
Found in python_dev_tools/whataformatter.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (80 > 79 characters)
Open

        with suppress(subprocess.CalledProcessError, subprocess.TimeoutExpired):
Severity: Minor
Found in python_dev_tools/whataformatter.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (86 > 79 characters)
Open

            config.cli_args[index] = re.sub(PYTHON_VERSION_REGEX, target_version, arg)
Severity: Minor
Found in python_dev_tools/whataformatter.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (87 > 79 characters)
Open

    FormatterConfig(name="docformatter", path="docformatter", cli_args=["--in-place"]),
Severity: Minor
Found in python_dev_tools/whataformatter.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (88 > 79 characters)
Open

                    for line in Path(orig_file).read_text(encoding="utf-8").splitlines()
Severity: Minor
Found in python_dev_tools/whataformatter.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (86 > 79 characters)
Open

    FormatterConfig(name="pybetter", path="pybetter", cli_args=["--exclude", "B004"]),
Severity: Minor
Found in python_dev_tools/whataformatter.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (88 > 79 characters)
Open

                    for line in Path(copy_file).read_text(encoding="utf-8").splitlines()
Severity: Minor
Found in python_dev_tools/whataformatter.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status