vragovR/safecrow-api

View on GitHub

Showing 8 of 8 total issues

Order has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class Order
{
    /**
     * @var string
     */
Severity: Minor
Found in src/Model/Order.php - About 3 hrs to fix

    Method handleRequest has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function handleRequest(RequestInterface $request, callable $next, callable $first): Promise
        {
            switch ($request->getMethod()) {
                case 'POST':
                    $data = sprintf(
    Severity: Minor
    Found in src/Plugin/AuthenticationPlugin.php - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          public function close(int $id, array $params) : Order
          {
              $resolver = new OptionsResolver();
              $resolver
                  ->setRequired([
      Severity: Major
      Found in src/Api/OrderApi.php and 3 other locations - About 1 hr to fix
      src/Api/OrderApi.php on lines 95..109
      src/Api/OrderApi.php on lines 116..130
      src/Api/OrderApi.php on lines 158..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          public function escalate(int $id, array $params) : Order
          {
              $resolver = new OptionsResolver();
              $resolver
                  ->setRequired([
      Severity: Major
      Found in src/Api/OrderApi.php and 3 other locations - About 1 hr to fix
      src/Api/OrderApi.php on lines 95..109
      src/Api/OrderApi.php on lines 116..130
      src/Api/OrderApi.php on lines 137..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          public function annul(int $id, array $params) : Order
          {
              $resolver = new OptionsResolver();
              $resolver
                  ->setRequired([
      Severity: Major
      Found in src/Api/OrderApi.php and 3 other locations - About 1 hr to fix
      src/Api/OrderApi.php on lines 116..130
      src/Api/OrderApi.php on lines 137..151
      src/Api/OrderApi.php on lines 158..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          public function cancel(int $id, array $params): Order
          {
              $resolver = new OptionsResolver();
              $resolver
                  ->setRequired([
      Severity: Major
      Found in src/Api/OrderApi.php and 3 other locations - About 1 hr to fix
      src/Api/OrderApi.php on lines 95..109
      src/Api/OrderApi.php on lines 137..151
      src/Api/OrderApi.php on lines 158..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function pay(int $id, array $params) : string
          {
              $resolver = new OptionsResolver();
              $resolver
                  ->setRequired([
      Severity: Minor
      Found in src/Api/OrderApi.php and 1 other location - About 40 mins to fix
      src/Api/UserApi.php on lines 119..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function bind(int $id, array $params): string
          {
              $resolver = new OptionsResolver();
              $resolver
                  ->setRequired([
      Severity: Minor
      Found in src/Api/UserApi.php and 1 other location - About 40 mins to fix
      src/Api/OrderApi.php on lines 74..88

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language