Sign upLogin

vshn/k8up

View on GitHub
Star
operator/backupcontroller/executor.go

Summary

Maintainability
C
1 day
Test Coverage

Method BackupExecutor.startBackup has 96 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (b *BackupExecutor) startBackup(ctx context.Context) error {
    ready, err := b.StartPreBackup(ctx)
    if err != nil {
        return err
    }
Severity: Major
Found in operator/backupcontroller/executor.go - About 2 hrs to fix

    Method BackupExecutor.listAndFilterPVCs has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
    Open

    func (b *BackupExecutor) listAndFilterPVCs(ctx context.Context, annotation string) ([]backupItem, error) {
    log := controllerruntime.LoggerFrom(ctx)

    pods := &corev1.PodList{}
    pvcPodMap := make(map[string]corev1.Pod)
    Severity: Minor
    Found in operator/backupcontroller/executor.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method BackupExecutor.listAndFilterPVCs has 78 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (b *BackupExecutor) listAndFilterPVCs(ctx context.Context, annotation string) ([]backupItem, error) {
    log := controllerruntime.LoggerFrom(ctx)

    pods := &corev1.PodList{}
    pvcPodMap := make(map[string]corev1.Pod)
    Severity: Major
    Found in operator/backupcontroller/executor.go - About 2 hrs to fix

      Method BackupExecutor.startBackup has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
      Open

      func (b *BackupExecutor) startBackup(ctx context.Context) error {
    ready, err := b.StartPreBackup(ctx)
    if err != nil {
        return err
    }
      Severity: Minor
      Found in operator/backupcontroller/executor.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method BackupExecutor.startBackup has 10 return statements (exceeds 4 allowed).
      Open

      func (b *BackupExecutor) startBackup(ctx context.Context) error {
    ready, err := b.StartPreBackup(ctx)
    if err != nil {
        return err
    }
      Severity: Major
      Found in operator/backupcontroller/executor.go - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (b *BackupExecutor) attachTLSVolumeMounts() []corev1.VolumeMount {
    var tlsVolumeMounts []corev1.VolumeMount
    if b.backup.Spec.Backend != nil && !utils.ZeroLen(b.backup.Spec.Backend.VolumeMounts) {
        tlsVolumeMounts = append(tlsVolumeMounts, *b.backup.Spec.Backend.VolumeMounts...)
    }
        Severity: Major
        Found in operator/backupcontroller/executor.go and 2 other locations - About 1 hr to fix
        operator/prunecontroller/executor.go on lines 144..151
        operator/checkcontroller/executor.go on lines 112..119

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 149.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status