Showing 23 of 23 total issues

Function rainbowText has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public static function rainbowText($text)
    {
        $colorsBase = array(
        array(255, 0, 0),
        array(255, 102, 0),
Severity: Minor
Found in holt45/Strings.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * Get.php
 */
namespace w3l\Holt45;
Severity: Major
Found in holt45/Get.php and 1 other location - About 3 hrs to fix
holt45/Post.php on lines 1..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * Post.php
 */
namespace w3l\Holt45;
Severity: Major
Found in holt45/Post.php and 1 other location - About 3 hrs to fix
holt45/Get.php on lines 1..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method allTests has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function allTests()
    {
        /* $_GET */
        if (self::chkGet("q")) {
            echo '$_GET["q"] is set';
Severity: Major
Found in Tests.php - About 2 hrs to fix

    Method kbdSymbol has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function kbdSymbol($inputKey, $inputOperatingSystem = "default")
        {
            $inputKey = mb_strtolower($inputKey);
            
            if ($inputOperatingSystem == "auto") {
    Severity: Major
    Found in holt45/Strings.php - About 2 hrs to fix

      Method rainbowText has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function rainbowText($text)
          {
              $colorsBase = array(
              array(255, 0, 0),
              array(255, 102, 0),
      Severity: Minor
      Found in holt45/Strings.php - About 1 hr to fix

        Method timeElapsed has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function timeElapsed($timestamp, $lang = "en", $countdown = false)
            {
                $arrayLanguages = array(
                "sv" => array("s" => ["sekund", "sekunder"],
                              "m" => ["minut", "minuter"],
        Severity: Minor
        Found in holt45/Time.php - About 1 hr to fix

          Method urlParser has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function urlParser($url)
              {
          
                  $parseUrl = self::autoCorrectParseUrl($url);
          
          
          Severity: Minor
          Found in holt45/Misc.php - About 1 hr to fix

            Method getBrowserAccessKeyModifiers has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function getBrowserAccessKeyModifiers(
                    $accessKey = null,
                    $getClientBrowser = "auto",
                    $getClientOS = "auto"
                ) {
            Severity: Minor
            Found in holt45/Browser.php - About 1 hr to fix

              Function urlParser has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function urlParser($url)
                  {
              
                      $parseUrl = self::autoCorrectParseUrl($url);
              
              
              Severity: Minor
              Found in holt45/Misc.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method decrypt has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function decrypt($string, $key)
                  {
                      $encryptedString = base64_decode($string);
                     
                      $initializationVector = substr(
              Severity: Minor
              Found in holt45/Strings.php - About 1 hr to fix

                Function hexrgb has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function hexrgb($hex)
                    {
                        $hex = preg_replace("/[^0-9A-Fa-f]/", '', $hex);
                
                        $strlenHex = strlen($hex);
                Severity: Minor
                Found in holt45/Convert.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function allTests has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function allTests()
                    {
                        /* $_GET */
                        if (self::chkGet("q")) {
                            echo '$_GET["q"] is set';
                Severity: Minor
                Found in Tests.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                                        if (count($colorsBuild) >= $strlenText) {
                                            continue 2;
                                        }
                Severity: Major
                Found in holt45/Strings.php - About 45 mins to fix

                  Method kbdShortcut has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          $inputArrayKeys,
                          $inputOperatingSystem = "default",
                          $inputKbdClass = "holt45-kbd",
                          $inputKbdSymbolClass = "holt45-kbd__symbol",
                          $inputJoinGlue = " + "
                  Severity: Minor
                  Found in holt45/Strings.php - About 35 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return $fallbackReturn;
                    Severity: Major
                    Found in holt45/Browser.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return null;
                      Severity: Major
                      Found in holt45/Browser.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return getenv('REMOTE_ADDR');
                        Severity: Major
                        Found in holt45/Browser.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return getenv('HTTP_FORWARDED');
                          Severity: Major
                          Found in holt45/Browser.php - About 30 mins to fix

                            Function generatePassword has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public static function generatePassword($length = 8, $passwordType = "long")
                                {
                                    $characterSet = "23456789abcdefghijkmnopqrstuvwxyzABCDEFGHJKLMNPRSTUVWXYZ!#%+:=?@";
                                    $characterSetLenght = (($passwordType == "simple") ? 33 : 64);
                            
                            
                            Severity: Minor
                            Found in holt45/Misc.php - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language